Skip to content

Add a new function GetOldVesion to VersionBumper to avoid duplicated version #12084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

chenlei-yang
Copy link
Contributor

Description

Add a new function GetOldVersion to VersionBumper and move the former logic into this new function. After getting the old version from the built module manifest, add two checkers to get versions from PSGallery and TestGallery to make sure the old version is the maximum version. So that it can ensure the generated version will not conflict with the preview version on PSGallery or TestGallery.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms self-assigned this Jun 8, 2020
@wyunchi-ms wyunchi-ms linked an issue Jun 8, 2020 that may be closed by this pull request
@VeryEarly VeryEarly merged commit a2ddd01 into Azure:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid duplicated version during version bump
3 participants