Skip to content

Fix update activity log alert rule when using ObjectInput from the pipe #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2020

Conversation

Avivskie
Copy link
Member

@Avivskie Avivskie commented Jun 10, 2020

this fixes the update alert rule issue.

Description

There is an issue when updating an alert when the alert rule is received and as InputObject.
This is because InputObject had duplicated Actions/Conditions.
The remove of the ctor solves this, it is seem unnecessary.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

this fixes the update alert rule issue.
@Avivskie Avivskie requested a review from InbalZim June 10, 2020 12:20
@Avivskie Avivskie changed the title remove duplication of action/conditions. Fix update activity alert rule when using ObjectInput from the pipe Jun 10, 2020
@Avivskie Avivskie changed the title Fix update activity alert rule when using ObjectInput from the pipe Fix update activity log alert rule when using ObjectInput from the pipe Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

CLA assistant check
All CLA requirements met.

@VeryEarly VeryEarly self-assigned this Jun 11, 2020
VeryEarly
VeryEarly previously approved these changes Jun 11, 2020
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for code changes please add ChangeLog next time

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit af0071b into Azure:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants