Skip to content

[Synapse] Updated parameter set for New-AzSynapseSparkPool to fix node count issue for auto scale #12128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 12, 2020

Conversation

wonner
Copy link
Contributor

@wonner wonner commented Jun 12, 2020

Description

This change updated parameter set for New-AzSynapseSparkPool to fix node count issue for auto scale. Here is the commandlet review PR: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/629

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wonner wonner requested a review from idear1203 June 12, 2020 02:40
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@ghost
Copy link

ghost commented Jun 12, 2020

CLA assistant check
All CLA requirements met.

idear1203
idear1203 previously approved these changes Jun 12, 2020
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@VeryEarly VeryEarly self-assigned this Jun 12, 2020
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the parameter sets should be called:
CreateByNameAndUnableAutoScaleParameterSet => CreateByNameAndDisableAutoScaleParameterSet
CreateByParentObjectAndUnableAutoScaleParameterSet => CreateByParentObjectAndDisableAutoScaleParameterSet

Please fix and regenerate help

@VeryEarly VeryEarly merged commit 6df7af4 into Azure:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants