Skip to content

[SQL] Add support for service principals for setting SQL AAD Admin. #12140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 13, 2020

Conversation

amolagar5
Copy link
Contributor

@amolagar5 amolagar5 commented Jun 13, 2020

Description

Add support for service principals for setting SQL AAD Admin.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@amolagar5 amolagar5 changed the title Amagarwa/dev/serviceprincipal as aad admin [SQL] Add support for service principals for setting SQL AAD Admin. Jun 13, 2020
@amolagar5 amolagar5 requested review from isra-fel and msJinLei June 13, 2020 00:17
@VeryEarly VeryEarly self-assigned this Jun 13, 2020
@VeryEarly
Copy link
Collaborator

Hi @amolagar ,

It looks like your changes not only added support for service principal lookup, but also replace application lookup, can you please confirm?

@amolagar5
Copy link
Contributor Author

Hi @amolagar ,

It looks like your changes not only added support for service principal lookup, but also replace application lookup, can you please confirm?

Applications are a subset of service principals, so it service principals will work, applications will automatically work.

@VeryEarly
Copy link
Collaborator

Hi @amolagar ,
It looks like your changes not only added support for service principal lookup, but also replace application lookup, can you please confirm?

Applications are a subset of service principals, so it service principals will work, applications will automatically work.

Thanks for the explanation.

@VeryEarly VeryEarly merged commit 320f759 into master Jun 13, 2020
@wyunchi-ms wyunchi-ms deleted the amagarwa/dev/serviceprincipalAsAADAdmin branch January 10, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants