Skip to content

NIC renaming changes for TFO/FO #12207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 30, 2020
Merged

NIC renaming changes for TFO/FO #12207

merged 8 commits into from
Jun 30, 2020

Conversation

subashchandra31
Copy link
Contributor

@subashchandra31 subashchandra31 commented Jun 18, 2020 •
edited
Loading

Description

  • NIC renaming changes for TFO/FO

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@ghost
Copy link

ghost commented Jun 18, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

punit-bhatt
punit-bhatt suggested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@punit-bhatt punit-bhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Cmdlet changes expected
  • Markdown changes expected
  • Design review expected
  • Null handling

@subashchandra31 subashchandra31 changed the title (Do not merge) NIC renaming changes for TFO/FO NIC renaming changes for TFO/FO Jun 18, 2020
@VeryEarly VeryEarly self-assigned this Jun 19, 2020
punit-bhatt
punit-bhatt suggested changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@punit-bhatt punit-bhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Markdown changes expected
  • Design review expected
  • Update ChangeLog

@subashchandra31
Copy link
Contributor Author

Cmdlet design review : Approved

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/648

VeryEarly
VeryEarly previously approved these changes Jun 29, 2020
View reviewed changes
@VeryEarly
Copy link
Collaborator

Hi @subashchandra31 ,

Please resolve the merge conflicts.

@subashchandra31
Copy link
Contributor Author

@VeryEarly handled merge conflicts..

VeryEarly
VeryEarly previously approved these changes Jun 29, 2020
View reviewed changes
@subashchandra31
Copy link
Contributor Author

subashchandra31 commented Jun 29, 2020 •
edited
Loading

@VeryEarly can u plz approve nd merge PR..

@subashchandra31 subashchandra31 added this to the S172 (2020-07-14) milestone Jun 29, 2020
@VeryEarly VeryEarly merged commit b8fb0f6 into Azure:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@punit-bhatt punit-bhatt punit-bhatt approved these changes

@ayfathim ayfathim Awaiting requested review from ayfathim

Assignees

@VeryEarly VeryEarly

@subashchandra31 subashchandra31

Labels
None yet
Projects
None yet
Milestone
S172 (2020-07-14)
Development

Successfully merging this pull request may close these issues.
6 participants
@subashchandra31 @adxsdkps @VeryEarly @ayfathim @punit-bhatt @azuresdkci