Skip to content

Rollback breaking changes from #12141 #12260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2020
Merged

Rollback breaking changes from #12141 #12260

merged 3 commits into from
Jun 29, 2020

Conversation

Xynoclafe
Copy link
Contributor

@Xynoclafe Xynoclafe commented Jun 24, 2020 •
edited
Loading

Description

Rollback breaking changes from #12141

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@Xynoclafe Xynoclafe requested a review from VeryEarly June 24, 2020 22:12
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@Xynoclafe Xynoclafe changed the title Rollback breaking changes from #12141 Rollback breaking changes from #12141 (https://github.com/Azure/azure-powershell/pull/12141) Jun 24, 2020
@Xynoclafe Xynoclafe changed the title Rollback breaking changes from #12141 (https://github.com/Azure/azure-powershell/pull/12141) Rollback breaking changes from #12141 Jun 24, 2020
@Xynoclafe Xynoclafe requested a review from filizt June 24, 2020 22:15
filizt
filizt approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@filizt filizt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might want to check the failed tasks.

@Xynoclafe
Copy link
Contributor Author

LGTM. You might want to check the failed tasks.

It seems to be failing build with some .NET version issue, but only on macOS while succeeding on Windows and Linux.
"The current .NET SDK does not support targeting .NET Core 2.2"

Let me try rerunning it.

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Jun 28, 2020
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit a1e52c1 into Azure:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@filizt filizt filizt approved these changes

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xynoclafe @adxsdkps @VeryEarly @filizt