Skip to content

Create Unregister-AzResourceProvider Cmdlet #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 2, 2020
Merged

Create Unregister-AzResourceProvider Cmdlet #12273

merged 7 commits into from
Jul 2, 2020

Conversation

diwudd
Copy link
Contributor

@diwudd diwudd commented Jun 26, 2020

Create Unregister-AzResourceProvider Cmdlet

@VeryEarly VeryEarly self-assigned this Jun 28, 2020
VeryEarly
VeryEarly requested changes Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update changelog, generate help for new cmdlets, add scenario test and record json

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@diwudd
Copy link
Contributor Author

diwudd commented Jun 29, 2020 via email

VeryEarly
VeryEarly requested changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fulfill the help markdown with:

  • online version
  • synopsis
  • description
  • examples

@diwudd
Copy link
Contributor Author

diwudd commented Jun 30, 2020 via email

@VeryEarly
Copy link
Collaborator

Hi @diwudd ,

Please check this log: https://dev.azure.com/azure-sdk/public/_build/results?buildId=442786&view=logs&jobId=b17395f6-68a3-5682-0476-d3f6f1043109&j=b17395f6-68a3-5682-0476-d3f6f1043109&t=67f633ab-4360-5839-af42-f446e0c847f0

those failed test cases need to be re-recorded due to the SDK upgrade.

@diwudd
Copy link
Contributor Author

diwudd commented Jul 1, 2020

Hi @diwudd ,

Please check this log: https://dev.azure.com/azure-sdk/public/_build/results?buildId=442786&view=logs&jobId=b17395f6-68a3-5682-0476-d3f6f1043109&j=b17395f6-68a3-5682-0476-d3f6f1043109&t=67f633ab-4360-5839-af42-f446e0c847f0

those failed test cases need to be re-recorded due to the SDK upgrade.

Thank you. Re-recorded the failed tests.

@VeryEarly VeryEarly merged commit 86382dd into Azure:master Jul 2, 2020
litchiyangMSFT pushed a commit to litchiyangMSFT/azure-powershell that referenced this pull request Aug 4, 2020
@diwudd @shenshengkafei @litchiyangMSFT
Create Unregister-AzResourceProvider Cmdlet (Azure#12273)
1c27c2e 
* Create UnregisterAzureProviderFeatureCmdlet

* Add help file and update change log

* record test

* Update Unregister-AzProviderFeature.md

* Update Unregister-AzProviderFeature.md

* Fix tags tests

Co-authored-by: shenshengkafei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diwudd @VeryEarly @azuresdkci @shenshengkafei