Skip to content

Networking Hybrid team minor but important PS changes #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2015

Conversation

Nilambari
Copy link
Member

  1. Added mandatory param to new dedicatedcircuit command let
  2. Added Set / Remove default site command lets
  3. Added new properties to return type of getconnection command let

1. Added mandatory param to new dedicatedcircuit command let
2. Added Set / Remove default site command lets
3. Added new properties to return type of getconnection command let
@azurecla
Copy link

azurecla commented Nov 3, 2015

Hi @Nilambari, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (nilamd). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Nov 3, 2015

@markcowl
Copy link
Member

markcowl commented Nov 3, 2015

@Nilambari It looks like network tests are failing - it appears that may be you need to upodate parameters in your powershell tests scripts to match these changes.

@markcowl
Copy link
Member

markcowl commented Nov 3, 2015

@Nilambari Looks like there's still a parameter issue in the test scripts:

-------- System.ArgumentNullException : Value cannot be null.
Parameter name: billingType

@Nilambari
Copy link
Member Author

Fixed the failing tests. Merge build is Passing now. Also, got on demand job:- http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/315/ successful.

Can you Please help merge this PR? Thanks a lot!

Thanks,
Nilambari

markcowl added a commit that referenced this pull request Nov 3, 2015
Networking Hybrid team minor but important PS changes
@markcowl markcowl merged commit 0881e5d into Azure:release-1.0.0 Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants