Fix for broken remove-datasource cmdlet #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2015 10:15
This fixes the broken remove data source cmdlet, which had inverted conditional logic that made it impossible to remove either type of data source. In addition to this fix, this change includes test cases specific to testing adding and removing data sources, to ensure this doesn't happen again. Finally, all tests were run against production for both DataLake* cmdlet services so that we have production recordings.
added 5 commits
November 4, 2015 15:51
Updating all tests to the latest framework. This helps resolve issues with mismatched framework dll discovery errors.
Shortening all test names and re-running them Fixing bugs in documentation Fast failing in Copy File if it exists and isn't meant to be overwritten.
reverting the change to the websites package in the tests project.
|
@azuresdkci retest this please |
|
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/324/ |
markcowl
added a commit
that referenced
this pull request
Nov 10, 2015
Fix for broken remove-datasource cmdlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken remove data source cmdlet, which had inverted
conditional logic that made it impossible to remove either type of data
source.
In addition to this fix, this change includes test cases specific to
testing adding and removing data sources, to ensure this doesn't happen
again.
Finally, all tests were run against production for both DataLake* cmdlet
services so that we have production recordings.