-
Notifications
You must be signed in to change notification settings - Fork 4k
Threat Detection new API + data masking chganges #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating data masking tests to work with MS25
Merger from Azure main
1. Adding Threat Detection new Set() and Get() API 2. Data masking - add PrivilegedUsers parameter and deprecate PrivilegedLogins parameter
Conflicts: ChangeLog.md
Merge from master
…into dev 27911c66943ff97abff1139ce5ce3ec3d8fc3ea. Conflicts: ChangeLog.md
@yaakoviyun There are merge conflicts, please update |
This reverts commit 627911c. Conflicts: ChangeLog.md
Resolving conflicts. |
/// <summary> | ||
/// The possible disable alert types | ||
/// </summary> | ||
public enum DetectionType { Successful_SQLi, Attempted_SQLi, Client_GEO_Anomaly, Failed_Logins_Anomaly, Failed_Queries_Anomaly, Data_Extraction_Anomaly, Data_Alteration_Anomaly }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaakoviyun line breaks
var storageV2Client = GetStorageV2Client(); | ||
var resourcesClient = GetResourcesClient(); | ||
var authorizationClient = GetAuthorizationManagementClient(); | ||
helper.SetupSomeOfManagementClients(sqlCSMClient, storageClient, storageV2Client, resourcesClient, authorizationClient); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line breaks
@yaakoviyun A few minor nits, otherwise lgtm |
…h MS25 deployed worldwide Fix all CR comment + adding some minor change for DM rule removal with MS25 deployed worldwide
markcowl
added a commit
that referenced
this pull request
Nov 11, 2015
Threat Detection new API + data masking chganges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.