Skip to content

Threat Detection new API + data masking chganges #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 11, 2015
Merged

Threat Detection new API + data masking chganges #1256

merged 21 commits into from
Nov 11, 2015

Conversation

yaakoviyun
Copy link
Member

No description provided.

yaakoviyun and others added 7 commits November 1, 2015 11:45
Updating data masking tests to work with MS25
Merger from Azure main
1. Adding Threat Detection new Set() and Get() API
2. Data masking - add PrivilegedUsers parameter and deprecate
PrivilegedLogins parameter
…into dev

27911c66943ff97abff1139ce5ce3ec3d8fc3ea.

Conflicts:
	ChangeLog.md
@markcowl
Copy link
Member

@yaakoviyun There are merge conflicts, please update

@yaakoviyun
Copy link
Member Author

Resolving conflicts.

/// <summary>
/// The possible disable alert types
/// </summary>
public enum DetectionType { Successful_SQLi, Attempted_SQLi, Client_GEO_Anomaly, Failed_Logins_Anomaly, Failed_Queries_Anomaly, Data_Extraction_Anomaly, Data_Alteration_Anomaly };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaakoviyun line breaks

var storageV2Client = GetStorageV2Client();
var resourcesClient = GetResourcesClient();
var authorizationClient = GetAuthorizationManagementClient();
helper.SetupSomeOfManagementClients(sqlCSMClient, storageClient, storageV2Client, resourcesClient, authorizationClient);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line breaks

@markcowl
Copy link
Member

@yaakoviyun A few minor nits, otherwise lgtm

…h MS25 deployed worldwide

Fix all CR comment + adding some minor change for DM rule removal with
MS25 deployed worldwide
markcowl added a commit that referenced this pull request Nov 11, 2015
Threat Detection new API + data masking chganges
@markcowl markcowl merged commit a91c23a into Azure:dev Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants