Skip to content

New cmdlet Invoke-AzVmPatchAssessment #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 14, 2020

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Aug 12, 2020

Description

Moved from #12608

Design: Azure/azure-powershell-cmdlet-review-pr#634

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@grizzlytheodore
Copy link
Member Author

@isra-fel Hello, this PR is moved here from #12608
We took your advice and changed the cmdlet name to Invoke-AzVmPatchAssessment, I always appreciate you looking at our work thoroughly and giving us input!
Anyways, following that I had some Git issues and the other pull request got messy so I created a new one.

@isra-fel isra-fel self-assigned this Aug 13, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Just one comment:

@grizzlytheodore
Copy link
Member Author

@isra-fel added Az.Compute.md

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isra-fel isra-fel merged commit 5f19e78 into Azure:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants