Skip to content

[Storage] Added breaking change warning message for upcoming cmdlet output change #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2020
Merged

[Storage] Added breaking change warning message for upcoming cmdlet output change #12898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
148397e
[Storage] Added breaking change warning message for upcoming cmdlet o…
blueww Sep 3, 2020
331b954
Add reference of KeyVault to Network.Test
Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Network/Network.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Sql.LegacySdk", "..\Sql\Sql
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PrivateDns", "..\PrivateDns\PrivateDns\PrivateDns.csproj", "{70D3A1D4-42FE-4697-AFC7-AC0FEAB0420B}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "KeyVault", "..\KeyVault\KeyVault\KeyVault.csproj", "{5423D705-89D5-47D8-8298-BF1342D3A808}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -112,10 +114,10 @@ Global
{70D3A1D4-42FE-4697-AFC7-AC0FEAB0420B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{70D3A1D4-42FE-4697-AFC7-AC0FEAB0420B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{70D3A1D4-42FE-4697-AFC7-AC0FEAB0420B}.Release|Any CPU.Build.0 = Release|Any CPU
{AD8D31C1-3C84-4213-A13A-A21C7440E591}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{AD8D31C1-3C84-4213-A13A-A21C7440E591}.Debug|Any CPU.Build.0 = Debug|Any CPU
{AD8D31C1-3C84-4213-A13A-A21C7440E591}.Release|Any CPU.ActiveCfg = Release|Any CPU
{AD8D31C1-3C84-4213-A13A-A21C7440E591}.Release|Any CPU.Build.0 = Release|Any CPU
{5423D705-89D5-47D8-8298-BF1342D3A808}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{5423D705-89D5-47D8-8298-BF1342D3A808}.Debug|Any CPU.Build.0 = Debug|Any CPU
{5423D705-89D5-47D8-8298-BF1342D3A808}.Release|Any CPU.ActiveCfg = Release|Any CPU
{5423D705-89D5-47D8-8298-BF1342D3A808}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand All @@ -131,6 +133,7 @@ Global
{1DE566DF-628F-4B55-8EBE-5077293169D8} = {95C16AED-FD57-42A0-86C3-2CF4300A4817}
{B71E1AFD-6A00-49BA-B18E-BF710B531E73} = {95C16AED-FD57-42A0-86C3-2CF4300A4817}
{70D3A1D4-42FE-4697-AFC7-AC0FEAB0420B} = {95C16AED-FD57-42A0-86C3-2CF4300A4817}
{5423D705-89D5-47D8-8298-BF1342D3A808} = {95C16AED-FD57-42A0-86C3-2CF4300A4817}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {81FE5D8D-D707-4DBC-9782-95E44EA873C3}
Expand Down
18 changes: 13 additions & 5 deletions src/Storage/Storage.Management/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,20 @@
## Upcoming Release
* Fixed upload blob fail by upgrade to Microsoft.Azure.Storage.DataMovement 2.0.0 [#12220]
* Supported Point In Time Restore
- Enable-AzStorageBlobRestorePolicy
- Disable-AzStorageBlobRestorePolicy
- New-AzStorageBlobRangeToRestore
- Restore-AzStorageBlobRange
- `Enable-AzStorageBlobRestorePolicy`
- `Disable-AzStorageBlobRestorePolicy`
- `New-AzStorageBlobRangeToRestore`
- `Restore-AzStorageBlobRange`
* Supported get blob restore status of Storage account by run get-AzureRMStorageAccount with parameter -IncludeBlobRestoreStatus
- Get-AzureRMStorageAccount
- `Get-AzureRMStorageAccount`
* Added breaking change warning message for upcoming cmdlet output change
- `Get-AzStorageContainerStoredAccessPolicy`
- `Set-AzStorageContainerStoredAccessPolicy`
- `Set-AzStorageAccountManagementPolicy`
- `Get-AzStorageAccountManagementPolicy`
- `Add-AzStorageAccountManagementPolicyAction`
- `New-AzStorageAccountManagementPolicyRule`


## Version 2.5.0
* Supported blob query acceleration
Expand Down
2 changes: 2 additions & 0 deletions ...Storage/Storage.Management/StorageAccount/AddAzureStorageAccountManagementPolicyAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
using Microsoft.Azure.Management.Storage;
using Microsoft.Azure.Management.Storage.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Globalization;
using System.Management.Automation;

namespace Microsoft.Azure.Commands.Management.Storage
{
[CmdletOutputBreakingChange(typeof(PSManagementPolicyActionGroup), ChangeDescription = "The type of sub child property DaysAfterModificationGreaterThan will change from int to int? in a future release.")]
[Cmdlet("Add", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "StorageAccountManagementPolicyAction", DefaultParameterSetName = BaseBlobParameterSet), OutputType(typeof(PSManagementPolicyActionGroup))]
public class AddAzureStorageAccountManagementPolicyActionCommand : StorageAccountBaseCmdlet
{
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/StorageAccount/GetAzureStorageAccountManagementPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.Azure.Management.Storage;
using Microsoft.Azure.Management.Storage.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Management.Automation;

namespace Microsoft.Azure.Commands.Management.Storage
{
[CmdletOutputBreakingChange(typeof(PSManagementPolicyActionGroup), ChangeDescription = "The type of sub child property DaysAfterModificationGreaterThan will change from int to int? in a future release.")]
[Cmdlet("Get", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "StorageAccountManagementPolicy", DefaultParameterSetName = AccountNameParameterSet), OutputType(typeof(PSManagementPolicy))]
public class GetAzureStorageAccountManagementPolicyCommand : StorageAccountBaseCmdlet
{
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccountManagementPolicyRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
using Microsoft.Azure.Management.Storage;
using Microsoft.Azure.Management.Storage.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System.Management.Automation;

namespace Microsoft.Azure.Commands.Management.Storage
{
[CmdletOutputBreakingChange(typeof(PSManagementPolicyActionGroup), ChangeDescription = "The type of sub child property DaysAfterModificationGreaterThan will change from int to int? in a future release.")]
[Cmdlet("New", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "StorageAccountManagementPolicyRule"), OutputType(typeof(PSManagementPolicyRule))]
public class NewAzureStorageAccountManagementPolicyRuleCommand : StorageAccountBaseCmdlet
{
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage.Management/StorageAccount/SetAzureStorageAccountManagementPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
using System.Globalization;
using System.Collections.Generic;
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

namespace Microsoft.Azure.Commands.Management.Storage
{
[CmdletOutputBreakingChange(typeof(PSManagementPolicyActionGroup), ChangeDescription = "The type of sub child property DaysAfterModificationGreaterThan will change from int to int? in a future release.")]
[Cmdlet("Set", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "StorageAccountManagementPolicy", SupportsShouldProcess = true, DefaultParameterSetName = AccountNamePolicyRuleParameterSet), OutputType(typeof(PSManagementPolicy))]
public class SetAzureStorageAccountManagementPolicyCommand : StorageAccountBaseCmdlet
{
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/Blob/Cmdlet/GetAzureStorageContainerStoredAccessPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet
{
using Common;
using Microsoft.Azure.Storage.Blob;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using Model.Contract;
using System;
using System.Globalization;
Expand All @@ -26,6 +27,7 @@ namespace Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet
/// <summary>
/// create a new azure container
/// </summary>
[CmdletOutputBreakingChange(typeof(SharedAccessBlobPolicy), ChangeDescription = "The output type will change from 'SharedAccessBlobPolicy' to 'PSObject', with the child property 'Permissions' type change from enum to string in a future release.")]
[Cmdlet("Get", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageContainerStoredAccessPolicy"), OutputType(typeof(SharedAccessBlobPolicy))]
public class GetAzureStorageContainerStoredAccessPolicyCommand : StorageCloudBlobCmdletBase
{
Expand Down
2 changes: 2 additions & 0 deletions src/Storage/Storage/Blob/Cmdlet/SetAzureStorageContainerStoredAccessPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ namespace Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet
{
using Common;
using Microsoft.Azure.Storage.Blob;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using Model.Contract;
using System;
using System.Globalization;
Expand All @@ -25,6 +26,7 @@ namespace Microsoft.WindowsAzure.Commands.Storage.Blob.Cmdlet
/// <summary>
/// create a new azure container
/// </summary>
[CmdletOutputBreakingChange(typeof(SharedAccessBlobPolicy), ChangeDescription = "The output type will change from 'SharedAccessBlobPolicy' to 'PSObject', with the child property 'Permissions' type change from enum to string in a future release.")]
[Cmdlet("Set", Azure.Commands.ResourceManager.Common.AzureRMConstants.AzurePrefix + "StorageContainerStoredAccessPolicy", SupportsShouldProcess = true), OutputType(typeof(String))]
public class SetAzureStorageContainerStoredAccessPolicyCommand : StorageCloudBlobCmdletBase
{
Expand Down