-
Notifications
You must be signed in to change notification settings - Fork 4k
Remove default for wmfversion for set cmdlets #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@eshaparmar No test coverage? |
@markcowl - we already have test coverage for this as scenario test and also in our daily CI system. This pr is only changing the default for this param when it is not present. |
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/340/ |
@eshaparmar There are failures in the on-demand run that are fixed in the dev branch. Please sync to the dev branch |
@eshaparmar Please update so that the on dermand run passes, or we will not be able to merge this PR. |
@narrieta @eshaparmar Code complete is today, so if this doesn't get updated, it will have to wait for the January release. |
No problem, it is a non-critical fix that can wait until the next release From: Mark Cowlishaw [mailto:[email protected]] @narrietahttps://github.com/narrieta @eshaparmarhttps://github.com/eshaparmar Code complete is today, so if this doesn't get updated, it will have to wait for the January release. — |
@eshaparmar Closing for now per discussion with Norberto. Please reopen when ready. |
This pr has been updated with the latest from azure dev |
Remove default for wmfversion for set cmdlets
No description provided.