Skip to content

Remove default for wmfversion for set cmdlets #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Dec 22, 2015
Merged

Remove default for wmfversion for set cmdlets #1291

merged 3 commits into from Dec 22, 2015

Conversation

eshaparmar
Copy link
Contributor

No description provided.

@markcowl
Copy link
Member

@eshaparmar No test coverage?

@eshaparmar
Copy link
Contributor Author

@markcowl - we already have test coverage for this as scenario test and also in our daily CI system. This pr is only changing the default for this param when it is not present.

@markcowl
Copy link
Member

@markcowl
Copy link
Member

@eshaparmar There are failures in the on-demand run that are fixed in the dev branch. Please sync to the dev branch

@markcowl
Copy link
Member

@eshaparmar Please update so that the on dermand run passes, or we will not be able to merge this PR.

@eshaparmar
Copy link
Contributor Author

@markcowl - I am out on vacation with limited internet access. I will let the team know about this. @narrieta

@markcowl
Copy link
Member

markcowl commented Dec 2, 2015

@narrieta @eshaparmar Code complete is today, so if this doesn't get updated, it will have to wait for the January release.

@narrieta
Copy link
Member

narrieta commented Dec 2, 2015

No problem, it is a non-critical fix that can wait until the next release

From: Mark Cowlishaw [mailto:[email protected]]
Sent: Wednesday, December 2, 2015 12:24 PM
To: Azure/azure-powershell [email protected]
Cc: Norberto Arrieta [email protected]
Subject: Re: [azure-powershell] Remove default for wmfversion for set cmdlets (#1291)

@narrietahttps://github.com/narrieta @eshaparmarhttps://github.com/eshaparmar Code complete is today, so if this doesn't get updated, it will have to wait for the January release.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1291#issuecomment-161422740.

@markcowl
Copy link
Member

markcowl commented Dec 2, 2015

@eshaparmar Closing for now per discussion with Norberto. Please reopen when ready.

@markcowl markcowl closed this Dec 2, 2015
@eshaparmar
Copy link
Contributor Author

This pr has been updated with the latest from azure dev
@markcowl - please merge this.

stankovski added a commit that referenced this pull request Dec 22, 2015
Remove default for wmfversion for set cmdlets
@stankovski stankovski merged commit 6ea5e08 into Azure:dev Dec 22, 2015
@eshaparmar eshaparmar deleted the wmfversion branch December 22, 2015 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants