[AzureRT] Sprint 56 update #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hyonholee
commented
Nov 13, 2015
hyonholee
commented
- Enable BGInfo by default
- Fix the issue when an OS disk is in a different resource group - Now New-AzureRmVM does not create a new storage account for boot diagnostics.
- Add a new test when an empty list for additional unattend content is set for Update-AzureRmVM.
- Re-record all compute tests because of New-AzureRmVM behavior change.
Re-record all compute tests. Add a new test when AUC is an empty list.
|
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/332/ |
| @@ -63,6 +63,7 @@ protected void ExecuteClientAction(Action action) | |||
| } | |||
| catch (CloudException ex) | |||
| { | |||
| base.EndProcessing(); | |||
There was a problem hiding this comment.
What if EndProcessing() shows exception? In that case, ComputeCloudException will be missed.
|
LGTM, other than 1 question about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.