-
Notifications
You must be signed in to change notification settings - Fork 4k
Breaking Change - Removed ApiVersion parameter from Az.Resources deployments cmdlets and changed the output type of Get-AzResourceGroupDeploymentOperations #13112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to xynoclafe/apiversion
…to xynoclafe/deploymentsSDKfix
…-powershell into xynoclafe/apiversion
…to xynoclafe/apiversion
Could you please fix the casing of "APi" in the class name? Refers to: src/Resources/ResourceManager/Implementation/CmdletBase/ResourceManagerCmdletBaseWithAPiVersion.cs:21 in 6c9887e. [](commit_id = 6c9887e, deletion_comment = False) |
src/Resources/Resources/ChangeLog.md
Outdated
@@ -18,6 +18,8 @@ | |||
- Additional information about change #1 | |||
--> | |||
## Upcoming Release | |||
* Updated `Get-AzResourceGroupDeploymentOperation`to use the SDK. | |||
* Remove ApiVersion parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a worthy effort to make the change longs a bit verbose to make things clear. We can add something like "Remove ApiVersion parameter from Deployment cmdlets" (if the cmdlet list is not too long, maybe add them too?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few cmdlets (mentioned in the design review), so I don't think adding them to the changelog is practical. But I'll make it a little more verbose.
Could you also add the link to the design discussion in the description section? |
@isra-fel Can you please review this PR? |
/azp run azure-powershell - windows-powershell |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Xynoclafe our team are just back from holiday. Anyway your changes LGTM. Thanks

/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @isra-fel |
…to xynoclafe/apiversion
@Xynoclafe I'm sorry but it seems the merge of #13090 has caused a lot of conflict in the test recording file. Would you please resolve them by merging master and record Thanks in advance! |
…to xynoclafe/apiversion
Description
Removed ApiVersion parameter from Az.Resources deployments cmdlets and changed the output type of Get-AzResourceGroupDeploymentOperations
This is a breaking change.
Design review - https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/707
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added