Get-AzVMBootDiagnostics api change to use RetrieveBootDiagnosticsData() #13233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…help doc update needed.
…re-powershell into SandidoBootDiagDataAPI
updating Azure.Storage.Blobs to 12.7.0 from 12.6.0 to address CI failure.
…to SandidoBootDiagDataAPI
|
Not getting input from PS reviewers in understanding the CI check failures, so marking this as Ready for Review to try and get feedback. |
Sandido
requested review from
bilaakpan-ms,
dkulkarni-ms,
grizzlytheodore,
haagha,
madewithsmiles and
MS-syh2qs
as code owners
to see if any effect on the CI checks.
|
/azp run |
Sandido
changed the title
|
Adding Do Not Merge because we are concerned with using a preview version for Azure.Storage.Blobs, despite it being required by the CI checks and PS team. |
Sandido
changed the title
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run azure-powershell - windows-powershell (Test) |
|
No pipelines are associated with this pull request. |
|
/azp run azure-powershell - windows-powershell |
|
Azure Pipelines successfully started running 1 pipeline(s). |
blueww
reviewed
Nov 5, 2020
src/Compute/Compute/VirtualMachine/Operation/GetAzureVMBootDiagnosticsDataCommand.cs
Outdated
Show resolved
Hide resolved
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No pipelines are associated with this pull request. |
avinashakka
reviewed
Nov 6, 2020
src/Compute/Compute/VirtualMachine/Operation/GetAzureVMBootDiagnosticsDataCommand.cs
Outdated
Show resolved
Hide resolved
isra-fel
approved these changes
Nov 9, 2020
|
/azp run azure-powershell - powershell-core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added