Acr API version upgrade, support network ruleset, new cmdlets for usage/import image/login #13237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryEarly
changed the title
yugangw-msft
previously approved these changes
Oct 18, 2020
src/ContainerRegistry/ContainerRegistry.Test/ScenarioTests/ContainerRegistryTests.ps1
Outdated
Show resolved
Hide resolved
src/ContainerRegistry/ContainerRegistry/Commands/ConnectAzureContainerRegistry.cs
Outdated
Show resolved
Hide resolved
src/ContainerRegistry/ContainerRegistry/Commands/NewAzureContainerRegistry.cs
Outdated
Show resolved
Hide resolved
| @@ -104,7 +109,7 @@ public override void ExecuteCmdlet() | |||
|
|
|||
| if (ShouldProcess(Name, "Update Container Registry")) | |||
| { | |||
| var registry = RegistryClient.UpdateRegistry(ResourceGroupName, Name, adminUserEnabled, Sku, storageAccountId, tags); | |||
| var registry = RegistryClient.UpdateRegistry(ResourceGroupName, Name, adminUserEnabled, Sku, storageAccountId, NetworkRuleSet, tags); | |||
| WriteObject(new PSContainerRegistry(registry)); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
For phase two, I suggest expose:
- AllowPublicNetworkAccess
- Enable/Disable data endpoint
|
LGTM |
8 tasks
isra-fel
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added