Intune powershell Cmdlets module #1328
Conversation
…ome input parameter changes
…hell into dev Conflicts: src/ResourceManager/Intune/Commands.Intune/Commands.Intune.csproj src/ResourceManager/Intune/Commands.Intune/SwaggerManifest/2015-01-05/IntuneSwaggerManifest.json
…emoval from manifest
| // You can specify all the values or you can default the Build and Revision Numbers | ||
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] |
There was a problem hiding this comment.
These should both match the module version (1.0.1)
|
@rnikhilkumar Please fix the version issues. The feedback I added on individual cmdlets applies across the board to many cmdlets - (1) OutputType should reflect the actual OutputType, (2) Only use ConfirmAction and Force on remove/update cmdlets, (3) You MUST NOT write messages to the output stream, (4) Your cmdlets would benefit from consolidating the different application types into a single add, get, and remove cmdlets where the user can specify the application type. These are usability issues that you will get negative feedback on from PowerShell users, but it is your call whether to fix these immediately (you have a day or two), or hold off for the next release. |
|
Waiting on on-demand job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/392/ |
|
|
||
| internal static void InitializeEnvironment() | ||
| { | ||
| Environment.SetEnvironmentVariable("AZURE_TEST_MODE", "Playback"); |
There was a problem hiding this comment.
@rnikhilkumar Please remove this - this will; prevent you from recording tests without help. This can wait until after the release, however.
|
@rnikhilkumar some changes which can be addressed next release. It looks like you have an app.config in your test project that needs to be removed (casuing failure). Once this is fixed and the builds pass, lgtm. |
|
@vrmurthy01 Please finalize your pull request asap if you want to include this in the 1.1.0 release. |
|
new on-demand: http://azuresdkci.cloudapp.net/job/powershell-demand/398/ |
Intune powershell Cmdlets module
Changes include