Skip to content

[Storage] Fix BlobType description in help of Set-AzStorageBlobContent #13314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

blueww
Copy link
Member

@blueww blueww commented Oct 23, 2020

Description

This PR is to add a sample script for Set ACL recursive.
Per before discussion with @dingmeng-xue , we can add this with a Reame.md file to point out which samples are included.

I don't add a changelog here, since the feature is just added with changelog in PR #13188, and the sample change should be a part of the feature.

The sample change won't impact the build and release of the coming Azure PSH release, so please help to merge it.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Updated parameter -BlobType description in help file of Set-AzStorageBlobContent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log is not required in a doc-only pull request. We push every doc of every module to docs.microsoft.com in every release :)

@blueww
Copy link
Member Author

blueww commented Oct 28, 2020

@isra-fel
I have removed the change log, please help to check.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@isra-fel isra-fel merged commit 742917b into Azure:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants