Skip to content

[DataFactory]improve documentation for cmdlet New-AzDataFactoryV2LinkedServiceEncryptedCredential #13356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

xumou-ms
Copy link
Contributor

@xumou-ms xumou-ms commented Oct 29, 2020

Description

improve documentation for cmdlet New-AzDataFactoryV2LinkedServiceEncryptedCredential

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel
Copy link
Member

isra-fel commented Nov 2, 2020

Hi @xumou-ms did you met any problem in Windows PowerShell or PowerShell below 7.0? Could you submit an issue if you did? Because we are still supporting those platforms.

@isra-fel
Copy link
Member

isra-fel commented Nov 2, 2020

@hvermis could you help review the help doc of New-AzDataFactoryV2LinkedServiceEncryptedCredential?
Thanks

@isra-fel isra-fel self-assigned this Nov 2, 2020
@xumou-ms
Copy link
Contributor Author

xumou-ms commented Nov 2, 2020

Hello @isra-fel. To meet Azure compliance requirements, we need to remove SSL self-signed cert from Self-Hosted IR. Which causes the underlying implementation isn't supported by .NET Standard 2.0. But .NET Core 3.1 can support that. So, PowerShell 7 is necessary.

@xumou-ms xumou-ms changed the title improve documentation for cmdlet New-AzDataFactoryV2LinkedServiceEncryptedCredential [ADF]improve documentation for cmdlet New-AzDataFactoryV2LinkedServiceEncryptedCredential Nov 2, 2020
@xumou-ms xumou-ms changed the title [ADF]improve documentation for cmdlet New-AzDataFactoryV2LinkedServiceEncryptedCredential [DataFactory]improve documentation for cmdlet New-AzDataFactoryV2LinkedServiceEncryptedCredential Nov 2, 2020
@isra-fel
Copy link
Member

isra-fel commented Nov 3, 2020

Hello @isra-fel. To meet Azure compliance requirements, we need to remove SSL self-signed cert from Self-Hosted IR. Which causes the underlying implementation isn't supported by .NET Standard 2.0. But .NET Core 3.1 can support that. So, PowerShell 7 is necessary.

Got it. I suppose it would be even better if we could do the check in code as well, so the cmdlet can fail fast.

BTW you could use the snippet $PSVersionTable.PSVersion -lt "7.0.0" to tell the version.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 832ca0e into Azure:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants