Skip to content

Adding firewall prerequisite information #13385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Adding firewall prerequisite information #13385

merged 1 commit into from
Nov 10, 2020

Conversation

johnmart82
Copy link
Contributor

While trying to follow the example in this page I was getting GatewayTimeout errors. After updating the firewall to allow Azure services the examples work fine. This is important information to the success of the reader executing the example code. As this is essential information required for user success it has been highlighted as Important.

Description

After trying to get the example code to work I tested with Allow azure services option enabled on the firewall. As this is important for the readers success when testing I have added it as Important information.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

While trying to follow the example in this page I was getting GatewayTimeout errors. After updating the firewall to allow Azure services the examples work fine. This is important information to the success of the reader executing the example code. As this is essential information required for user success it has been highlighted as Important.
@ghost ghost added the customer-reported label Oct 31, 2020
@ghost
Copy link

ghost commented Oct 31, 2020

Thank you for your contribution johnmart82! We will review the pull request and get back to you soon.

@isra-fel
Copy link
Member

isra-fel commented Nov 2, 2020

Thanks for your contribution again @johnmart82 !
@brandong-ms @xaliciayang could you review the change to the doc of New-AzSqlDatabaseExport, or suggest someone to review please? Thank you

@isra-fel isra-fel self-assigned this Nov 2, 2020
@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2020

@mikefrobbins Hello Mike could you help Sql team to review this PR? Thanks in advance 😀

@msJinLei
Copy link
Contributor

msJinLei commented Nov 9, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel added this to the S178 (2020-11-17) milestone Nov 10, 2020
@isra-fel
Copy link
Member

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 58ca05d into Azure:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants