Skip to content

{VirtualWan} Mark rtv1 and rtv2 as to be deprecated #13394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

{VirtualWan} Mark rtv1 and rtv2 as to be deprecated #13394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ public class NewAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
HelpMessage = "The hub virtual network connections associated with this Virtual Hub.")]
public PSHubVirtualNetworkConnection[] HubVnetConnection { get; set; }

public const String RTv1ChangeDesc = "Parameter is being deprecated without being replaced. Use *VHubRouteTable* commands.";
[CmdletParameterBreakingChange("RouteTable", ChangeDescription = RTv1ChangeDesc)]
[Parameter(
Mandatory = false,
HelpMessage = "The route table associated with this Virtual Hub.")]
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubRouteCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[CmdletDeprecation(ReplacementCmdletName = "Add-AzVirtualHubRoute")]
[CmdletDeprecation(ReplacementCmdletName = "New-AzVHubRoute")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the command name change here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially we marked this deprecated and pointed it to use rtv2, so now replaced it to point to rtv3

[Cmdlet(
VerbsCommon.New,
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRoute",
Expand Down
2 changes: 1 addition & 1 deletion src/Network/Network/Cortex/VirtualHub/NewAzureRmVirtualHubRouteTableCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[CmdletDeprecation(ReplacementCmdletName = "Add-AzVirtualHubRouteTable")]
[CmdletDeprecation(ReplacementCmdletName = "New-AzVHubRouteTable")]
[Cmdlet(VerbsCommon.New,
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRouteTable",
SupportsShouldProcess = false),
Expand Down
3 changes: 3 additions & 0 deletions src/Network/Network/Cortex/VirtualHub/SetAzureRmVirtualHubCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
using System.Linq;
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[Cmdlet("Set",
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHub",
Expand Down Expand Up @@ -72,6 +73,8 @@ public class SetAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
[ValidateNotNullOrEmpty]
public PSVirtualHub InputObject { get; set; }

public const String RTv2ChangeDesc = "Parameter is being deprecated without being replaced. Use *VHubRouteTable* commands.";
[CmdletParameterBreakingChange("RouteTable", ChangeDescription = RTv2ChangeDesc)]
[Parameter(
Mandatory = true,
HelpMessage = "The route tables associated with this Virtual Hub.")]
Expand Down
2 changes: 2 additions & 0 deletions src/Network/Network/Cortex/VirtualHub/UpdateAzureRmVirtualHubCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ public class UpdateAzureRmVirtualHubCommand : VirtualHubBaseCmdlet
HelpMessage = "The hub virtual network connections associated with this Virtual Hub.")]
public PSHubVirtualNetworkConnection[] HubVnetConnection { get; set; }

public const String RTv1ChangeDesc = "Parameter is being deprecated without being replaced. Use *VHubRouteTable* commands.";
[CmdletParameterBreakingChange("RouteTable", ChangeDescription = RTv1ChangeDesc)]
[Parameter(
Mandatory = false,
HelpMessage = "The route table associated with this Virtual Hub.")]
Expand Down
2 changes: 2 additions & 0 deletions src/Network/Network/Cortex/VirtualHubRouteTable/AddAzureRmVirtualHubRouteCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Commands.Network.Models;
using System.Linq;
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[CmdletDeprecation(ReplacementCmdletName = "New-AzVHubRoute")]
[Cmdlet(
VerbsCommon.Add,
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRoute",
Expand Down
2 changes: 2 additions & 0 deletions src/Network/Network/Cortex/VirtualHubRouteTable/AddAzureRmVirtualHubRouteTableCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Commands.Network.Models;
using System.Linq;
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[CmdletDeprecation(ReplacementCmdletName = "New-AzVHubRouteTable")]
[Cmdlet(VerbsCommon.Add,
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRouteTable",
SupportsShouldProcess = false),
Expand Down
2 changes: 2 additions & 0 deletions src/Network/Network/Cortex/VirtualHubRouteTable/GetAzureRmVirtualHubRouteTableCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.Azure.Management.Network.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;
using System;
using System.Collections.Generic;
using System.Management.Automation;

[CmdletDeprecation(ReplacementCmdletName = "Get-AzVHubRouteTable")]
[Cmdlet(VerbsCommon.Get,
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRouteTable",
DefaultParameterSetName = CortexParameterSetNames.ByVirtualHubName),
Expand Down
2 changes: 2 additions & 0 deletions src/Network/Network/Cortex/VirtualHubRouteTable/RemoveAzureRmVirtualHubRouteTableCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ namespace Microsoft.Azure.Commands.Network
using Microsoft.Azure.Commands.Network.Models;
using Microsoft.Azure.Commands.ResourceManager.Common.ArgumentCompleters;
using Microsoft.Azure.Management.Internal.Resources.Utilities.Models;
using Microsoft.WindowsAzure.Commands.Common.CustomAttributes;

[CmdletDeprecation(ReplacementCmdletName = "Remove-AzVHubRouteTable")]
[Cmdlet(VerbsCommon.Remove,
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualHubRouteTable",
DefaultParameterSetName = CortexParameterSetNames.ByVirtualHubRouteTableName,
Expand Down