Skip to content

New-AzVm and New-AzVmConfig licenseType description edits #13407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

Sandido
Copy link
Contributor

@Sandido Sandido commented Nov 3, 2020

Work for https://msazure.visualstudio.com/One/_workitems/edit/8323663.
The AzVM documentation in PS had similar incorrect text stating the LicenseType cannot be updated, when in fact it can be.
The VMSS documentation had no mention of LicenseType and so is not included here.
I improved the New-AzVmConfig LicenseType description while I was in the area.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

grizzlytheodore
grizzlytheodore previously approved these changes Nov 3, 2020
Copy link
Member

@grizzlytheodore grizzlytheodore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@isra-fel
Copy link
Member

isra-fel commented Nov 4, 2020

LGTM too. @Sandido let me know when it's ready to merge please

@isra-fel
Copy link
Member

isra-fel commented Nov 4, 2020

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@Sandido
Copy link
Contributor Author

Sandido commented Nov 5, 2020

Ready to merge.

@isra-fel
Copy link
Member

isra-fel commented Nov 6, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel assigned isra-fel and unassigned Sandido Nov 6, 2020
@isra-fel isra-fel merged commit d43632f into master Nov 6, 2020
@isra-fel isra-fel deleted the SandidoLicenseTypeDesc branch November 6, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants