Skip to content

Remove-AzSynapseSqlPoolRestorePoint #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 27, 2020
Merged

Remove-AzSynapseSqlPoolRestorePoint #13412

merged 11 commits into from
Nov 27, 2020

Conversation

zesluo
Copy link

@zesluo zesluo commented Nov 4, 2020 •
edited
Loading

Description

This change add some SQL pool related cmdlets, and change some exist cmdlets to keep align with SQL. Here is the commandlet review PR:Azure/azure-powershell-cmdlet-review-pr#783

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Nov 4, 2020
@ghost
Copy link

ghost commented Nov 4, 2020

Thank you for your contribution zesluo! We will review the pull request and get back to you soon.

@zesluo zesluo changed the title Remove-AzSynapseSqlPoolRestorePoint Remove-AzSynapseSqlPoolRestorePoint(This is just a draft) Nov 4, 2020
@idear1203 idear1203 marked this pull request as draft November 4, 2020 03:22
wonner
wonner reviewed Nov 4, 2020
View reviewed changes
idear1203
idear1203 reviewed Nov 16, 2020
View reviewed changes
wonner
wonner reviewed Nov 17, 2020
View reviewed changes
idear1203
idear1203 reviewed Nov 17, 2020
View reviewed changes
idear1203
idear1203 reviewed Nov 17, 2020
View reviewed changes
idear1203
idear1203 reviewed Nov 18, 2020
View reviewed changes
idear1203
idear1203 previously approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@idear1203 idear1203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

wonner
wonner reviewed Nov 19, 2020
View reviewed changes
@zesluo zesluo changed the title Remove-AzSynapseSqlPoolRestorePoint(This is just a draft) Remove-AzSynapseSqlPoolRestorePoint Nov 23, 2020
@idear1203
Copy link
Contributor

Please update the session records as well

idear1203
idear1203 reviewed Nov 26, 2020
View reviewed changes
@idear1203 idear1203 marked this pull request as ready for review November 26, 2020 06:55
@idear1203 idear1203 force-pushed the zeshi/RemoveSqlPoolRestorePoint branch from 8f3ed46 to 1ebf013 Compare November 26, 2020 11:05
@zesluo zesluo force-pushed the zeshi/RemoveSqlPoolRestorePoint branch from bb7854a to 623ae28 Compare November 26, 2020 11:30
@idear1203 idear1203 force-pushed the zeshi/RemoveSqlPoolRestorePoint branch from 623ae28 to 0553da0 Compare November 26, 2020 11:46
@msJinLei msJinLei merged commit 09627e4 into Azure:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idear1203 idear1203 idear1203 left review comments

@wonner wonner wonner left review comments

@msJinLei msJinLei msJinLei approved these changes

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zesluo @idear1203 @wonner @msJinLei @azuresdkci @zesluo1