#10518-webapp: Support the new appservice Managed certificates

[Kotasudhakarreddy]

#10518

Description

Appservice released the new preview feature at Ignite 2019 https://azure.github.io/AppService/2019/11/04/Announcing-Managed-Certificates.html
We need first class command support for this feature using PowerShell
Design Review- https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/663

Created new cmdlets:
-New-AzWebAppManagedCertificate
-Remove-AzWebAppManagedCertificate
Testing:
1.New-AzWebAppManagedCertificate -ResourceGroupName Default-Web-WestUS -WebAppName "ContosoSite" -HostName "www.ContosoSite.net" - To create a new managed certificate
2. Remove-AzWebAppManagedCertificate -ResourceGroupName Default-Web-WestUS -WebAppName "ContosoSite" -HostName "www.ContosoSite.net" -Thumbprint "E3A38EBA60CAA1C162785A2E1C44A15AD450199C3" - To remove the managed certificate

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[Kotasudhakarreddy]

@panchagnula - For your review. Working on build failure.

[Kotasudhakarreddy]

@ThejaChoudary - FYI.

[panchagnula]

A few comments to address.

[msJinLei]

  Processing complete for analyzer: Breaking Change Analyzer
  D:\a\1\s\artifacts//StaticAnalysisResults\SignatureIssues.csv Errors
  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "D:\a\1\s\artifacts\Debug\Az.Websites\Microsoft.Azure.PowerShell.Cmdlets.Websites.dll","Microsoft.Azure.Commands.WebApps.Cmdlets.Certificates.NewAzWebAppManagedCertificate","New-AzWebAppManagedCertificate","1","8100","New-AzWebAppManagedCertificate Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
  "D:\a\1\s\artifacts\Debug\Az.Websites\Microsoft.Azure.PowerShell.Cmdlets.Websites.dll","Microsoft.Azure.Commands.WebApps.Cmdlets.Certificates.RemoveAzWebAppManagedCertificate","Remove-AzWebAppManagedCertificate","1","8100","Remove-AzWebAppManagedCertificate Does not support ShouldProcess but the cmdlet verb Remove indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
  
  
  D:\a\1\s\artifacts//StaticAnalysisResults\SignatureIssues.csv:
  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "D:\a\1\s\artifacts\Debug\Az.Websites\Microsoft.Azure.PowerShell.Cmdlets.Websites.dll","Microsoft.Azure.Commands.WebApps.Cmdlets.Certificates.NewAzWebAppManagedCertificate","New-AzWebAppManagedCertificate","1","8100","New-AzWebAppManagedCertificate Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
  

Please implement shouldprocess for NewAzWebAppManagedCertificate and RemoveAzWebAppManagedCertificate

[Kotasudhakarreddy]

@ThejaChoudary FYI.

[msJinLei]

LGTM. Wait for other reviewers's approval

[msJinLei]

@Kotasudhakarreddy please remove service attention label after review out of azure powershell team is finished

[Kotasudhakarreddy]

@Kotasudhakarreddy please remove service attention label after review out of azure powershell team is finished

Sure @msJinLei

[msJinLei]

@Kotasudhakarreddy please remove service attention label after review out of azure powershell team is finished

Sure @msJinLei

But still see @panchagnula request a change. Is the review of @panchagnula finished?

[msJinLei]

@Kotasudhakarreddy please remove service attention label after review out of azure powershell team is finished

Sure @msJinLei

But still see @panchagnula request a change. Is the review of @panchagnula finished?

kindly ping @panchagnula and @Kotasudhakarreddy

[panchagnula]

@Kotasudhakarreddy please remove service attention label after review out of azure powershell team is finished

Sure @msJinLei

But still see @panchagnula request a change. Is the review of @panchagnula finished?

kindly ping @panchagnula and @Kotasudhakarreddy

@msJinLei I had asked Kota to make one more change on this so yes - not ready for merging yet. Thanks!

[panchagnula]

LGTM! Thank you for adding support to this.