New-AzApiManagementProduct: Change SubscriptionsLimit parameter default value to None

[SteppingRazor]

Description

You can read the whole story here
Short story: using Azure Rest Api or Azure portal it is possible to create product with SubscriptionRequired set to true but leave SubscriptionsLimit unlimited. As for New-AzApiManagementProduct command there is no reason to default SubscriptionsLimit to 1 when user set SubscriptionRequired to true

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[ghost]

Thank you for your contribution SteppingRazor! We will review the pull request and get back to you soon.

[ghost]

All CLA requirements met.

[isra-fel]

Hi @SteppingRazor thanks for your contribution 👍
@solankisamir could you help review this change because you updated the cmdlet? Thanks!

[isra-fel]

I just checked Azure portal, the default behavior when you enable "Requires subscription" is to have no limit, so I agree with the proposed changes.

I will work on your pull request (if you don't mind) with:

1. Update test cases to cover this new behavior
2. Modify the change log to mention this is a breaking change

[isra-fel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[isra-fel]

LGTM

[isra-fel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).