Skip to content

refactor diagnostic setting #13535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2020
Merged

refactor diagnostic setting #13535

merged 4 commits into from
Dec 2, 2020

Conversation

VeryEarly
Copy link
Collaborator

@VeryEarly VeryEarly commented Nov 18, 2020 •
edited
Loading

Description

cmdlet design

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly force-pushed the refactor-diagnosticsetting branch 2 times, most recently from 131e56a to dbb9250 Compare November 19, 2020 08:49
@VeryEarly VeryEarly marked this pull request as ready for review November 19, 2020 08:57
@VeryEarly VeryEarly force-pushed the refactor-diagnosticsetting branch 3 times, most recently from 4ab7e4c to 7095257 Compare November 20, 2020 01:55
@VeryEarly VeryEarly self-assigned this Nov 20, 2020
@VeryEarly VeryEarly force-pushed the refactor-diagnosticsetting branch from 7095257 to 1591835 Compare November 23, 2020 07:11
@VeryEarly VeryEarly force-pushed the refactor-diagnosticsetting branch from 1591835 to db11568 Compare November 23, 2020 07:28
@VeryEarly
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

dingmeng-xue
dingmeng-xue reviewed Nov 30, 2020
View reviewed changes
dingmeng-xue
dingmeng-xue reviewed Nov 30, 2020
View reviewed changes
@VeryEarly
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

dingmeng-xue
dingmeng-xue previously approved these changes Dec 1, 2020
View reviewed changes
@dingmeng-xue dingmeng-xue changed the base branch from master to release-2020-12-08 December 2, 2020 03:54
@dingmeng-xue dingmeng-xue dismissed their stale review December 2, 2020 03:54

The base branch was changed.

@dingmeng-xue dingmeng-xue merged commit 1b71552 into Azure:release-2020-12-08 Dec 2, 2020
@VeryEarly VeryEarly linked an issue Dec 7, 2020 that may be closed by this pull request
Set-AzDiagnosticSetting - impossible to set RentionInDays for individual categories #11589
Closed
@VeryEarly VeryEarly mentioned this pull request Dec 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set-AzDiagnosticSetting - impossible to set RentionInDays for individual categories
3 participants
@VeryEarly @dingmeng-xue @azuresdkci