Skip to content

[Storage] Upgrade Azure.Storage.Queues to 12.5.0 #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

blueww
Copy link
Member

@blueww blueww commented Nov 30, 2020

Description

Azure.Storage.Queues to 12.5.0 has a new dependency "System.Memory.Data" 1.0.0

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@msJinLei
Copy link
Contributor

msJinLei commented Dec 1, 2020

Hi @blueww, there is a signature issue reported.

  D:\a\1\s\artifacts//StaticAnalysisResults\MissingAssemblies.csv:
  "Directory","Assembly Name","Assembly Version","Referencing Assembly","Severity","ProblemId","Description","Remediation"
  "D:\a\1\s\artifacts/Debug\Az.Storage","System.Memory.Data","1.0.0.0","Azure.Storage.Queues","0","3000","Missing assembly System.Memory.Data referenced from Azure.Storage.Queues","Ensure that the assembly is included in the Wix file or directory"
 

It seems that you need to add it to package reference.

@blueww
Copy link
Member Author

blueww commented Dec 1, 2020

@erich-wang
I have added a new dll "System.Memory.Data" to
src/Accounts/Authentication/Utilities/CustomAssemblyResolver.cs
src/lib/NetCorePreloadAssemblies/System.Memory.Data.dll
src/lib/NetFxPreloadAssemblies/System.Memory.Data.dll 

But still meet analysis failure. Do I still need to add it to package reference? Is there any sample?

@blueww
Copy link
Member Author

blueww commented Dec 1, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms self-assigned this Dec 1, 2020
@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@blueww
Copy link
Member Author

blueww commented Dec 2, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@blueww
Copy link
Member Author

blueww commented Dec 8, 2020

@wyunchi-ms
Would you please help to see why the test fail?
It seems not related with my change. Let me know if any action I need to take.

The test failed in 2 test cases:

2020-12-07T06:15:19.4780170Z     ! Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SparkJobTests.TestSynapseSparkJob [1ms]
2020-12-07T06:15:21.3440900Z   [xUnit.net 00:00:11.54]     Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SqlPoolTests.TestSynapseSqlPoolSecurity [FAIL]
2020-12-07T06:15:22.5422590Z     X Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SqlPoolTests.TestSynapseSqlPoolSecurity [604ms]
2020-12-07T06:15:22.5427060Z EXEC : error Message:  [/Users/runner/work/1/s/build.proj]
2020-12-07T06:15:22.5429240Z      System.Management.Automation.CommandNotFoundException : The term 'Update-AzSynapseSqlPoolAdvancedThreatProtectionSetting' is not recognized as the name of a cmdlet, function, script file, or operable program.
2020-12-07T06:15:22.5430610Z   Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
2020-12-07T06:15:18.9905890Z   [xUnit.net 00:00:09.20]     Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.WorkspaceTests.TestSynapseWorkspaceSecurity [FAIL]
2020-12-07T06:15:19.0688520Z   [xUnit.net 00:00:09.24]     Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.SparkJobTests.TestSynapseSparkJob [SKIP]
2020-12-07T06:15:19.4281140Z     ! Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.WorkspaceTests.TestSynapseWorkspaceActiveDirectoryAdministrator [1ms]
2020-12-07T06:15:19.4283060Z     X Microsoft.Azure.Commands.Synapse.Test.ScenarioTests.WorkspaceTests.TestSynapseWorkspaceSecurity [946ms]
2020-12-07T06:15:19.4374620Z EXEC : error Message:  [/Users/runner/work/1/s/build.proj]
2020-12-07T06:15:19.4377220Z      System.Management.Automation.CommandNotFoundException : The term 'Enable-AzSynapseSqlAdvancedDataSecurity' is not recognized as the name of a cmdlet, function, script file, or operable program.
2020-12-07T06:15:19.4379090Z   Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit a5d00a0 into Azure:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants