Skip to content

[Synapse] Fix deserialization issue for creating Pipeline/Dataset/Trigger #13643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 9, 2020

Conversation

wonner
Copy link
Contributor

@wonner wonner commented Dec 2, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

Could you please offer the diff of these data models such as DataFlow as PSDataFlow.

@wonner
Copy link
Contributor Author

wonner commented Dec 7, 2020

Could you please offer the diff of these data models such as DataFlow as PSDataFlow.

DataFlow is a model in SDK, it has some subclasses such as MappingDataFlow. In the previous code, we only return the wrapper class PSDataFlow, it will miss the properties in subclass. So we keep align with ADF here, just provided the real data flow sub type. (In ADF, the link is: DataFlow Class (Microsoft.Azure.Management.DataFactory.Models) - Azure for .NET Developers | Microsoft Docs)

@wonner
Copy link
Contributor Author

wonner commented Dec 7, 2020

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit b2d1d8b into Azure:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants