Skip to content

[#108127818] Fixed issues with token id that does not match incoming account id #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2015
Merged

Conversation

hovsepm
Copy link
Contributor

@hovsepm hovsepm commented Nov 29, 2015

No description provided.

@hovsepm
Copy link
Contributor Author

hovsepm commented Nov 29, 2015

@hovsepm hovsepm changed the title Fixed issues with token id that does not match incoming account id [#108127818] Fixed issues with token id that does not match incoming account id Nov 30, 2015
accountId = account.Id;
account.SetOrAppendProperty(AzureAccount.Property.Tenants, tenant);
}
else if (accountId == account.Id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to control the strong comparison, I would use string.Equals, with StringComparison.OrdinalIgnoreCase

@hovsepm
Copy link
Contributor Author

hovsepm commented Dec 1, 2015

markcowl added a commit that referenced this pull request Dec 1, 2015
[#108127818] Fixed issues with token id that does not match incoming account id
@markcowl markcowl merged commit 9a872b4 into Azure:dev Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants