Get-AzKeyVaultSecret can -AsPlainText #13730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
commented
Dec 14, 2020
| Set-AzKeyVaultSecret -VaultName $vaultName -Name $secretName -SecretValue (ConvertTo-SecureString $secretTextV2 -AsPlainText -Force) | ||
|
|
||
| Describe "Get secret" { | ||
| It "should write secrets in plain text if -AsPlainText" { |
There was a problem hiding this comment.
It's a data-plane API, so I wrote a liveonly test here
| @@ -22,9 +22,6 @@ | |||
|
|
|||
| namespace Microsoft.Azure.Commands.KeyVault | |||
| { | |||
| [GenericBreakingChange("If you have soft-delete protection enabled on this key vault, this secret will be moved to the soft deleted state. " + | |||
There was a problem hiding this comment.
This should have been removed in last major release
wyunchi-ms
reviewed
Dec 14, 2020
wyunchi-ms
approved these changes
Dec 15, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #13630
If you Get-AzKeyVaultSecret -AsPlainText , it will just return a plain text secret string, instead of a secret object.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added