Skip to content

Deployment Scripts GA - update api-version #13737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2020
Merged

Deployment Scripts GA - update api-version #13737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a32e05
Update deploymentScripts apiVersion to latest GA version
jorgecotillo Dec 14, 2020
9d2b72b
update changelog
jorgecotillo Dec 14, 2020
0f192cb
Update ChangeLog.md
wyunchi-ms Dec 15, 2020
1e2fece
Fix template spec error type
jorgecotillo Dec 15, 2020
9efda69
Merge branch 'master' of https://github.com/jorgecotillo/azure-powers…
jorgecotillo Dec 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Resources/ResourceManager/ResourceManager.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<ItemGroup>
<PackageReference Include="AutoMapper" Version="6.2.2" />
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.10.0-preview" />
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="3.11.0-preview" />
<PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="2.2.0" />
</ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/Resources/ResourceManager/SdkClient/TemplateSpecsSdkClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ private TemplateSpec GetAzureSdkTemplateSpec(
catch (Exception ex)
{
if (!throwIfNotExists &&
ex is DefaultErrorResponseException dex &&
ex is TemplateSpecsErrorException dex &&
dex.Response.StatusCode == System.Net.HttpStatusCode.NotFound)
{
// Template spec does not exist
Expand Down Expand Up @@ -164,7 +164,7 @@ internal TemplateSpecVersion GetAzureSdkTemplateSpecVersion(
catch (Exception ex)
{
if (!throwIfNotExists &&
ex is DefaultErrorResponseException dex &&
ex is TemplateSpecsErrorException dex &&
dex.Response.StatusCode == System.Net.HttpStatusCode.NotFound)
{
// Template spec version does not exist
Expand Down
2 changes: 1 addition & 1 deletion src/Resources/Resources.Test/Resources.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Update="Microsoft.Azure.Management.ResourceManager" Version="3.10.0-preview" />
<PackageReference Update="Microsoft.Azure.Management.ResourceManager" Version="3.11.0-preview" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="FluentAssertions" Version="5.9.0" />
Expand Down
15,659 changes: 430 additions & 15,229 deletions ...Tests.DeploymentScriptsTests/TestDeploymentScriptGetAllDeploymentScriptPropertiesCli.json
View file
Open in desktop

Large diffs are not rendered by default.

8,834 changes: 511 additions & 8,323 deletions ...rioTests.DeploymentScriptsTests/TestDeploymentScriptGetDeploymentScriptWithBadScript.json
View file
Open in desktop

Large diffs are not rendered by default.

26,887 changes: 22,676 additions & 4,211 deletions ...ds.Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptGetForCli.json
View file
Open in desktop

Large diffs are not rendered by default.

29,115 changes: 543 additions & 28,572 deletions ...urces.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptGetForPowerShell.json
View file
Open in desktop

Large diffs are not rendered by default.

21,234 changes: 600 additions & 20,634 deletions ...Resources.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptLogGetForCli.json
View file
Open in desktop

Large diffs are not rendered by default.

19,695 changes: 558 additions & 19,137 deletions ...es.Test.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptLogGetForPowerShell.json
View file
Open in desktop

Large diffs are not rendered by default.

14,578 changes: 674 additions & 13,904 deletions ...Tests.DeploymentScriptsTests/TestDeploymentScriptPipeDeploymentScriptObjectToGetLogs.json
View file
Open in desktop

Large diffs are not rendered by default.

13,700 changes: 424 additions & 13,276 deletions ...t.ScenarioTests.DeploymentScriptsTests/TestDeploymentScriptRemoveDeploymentScriptCli.json
View file
Open in desktop

Large diffs are not rendered by default.

20,230 changes: 539 additions & 19,691 deletions ...rioTests.DeploymentScriptsTests/TestDeploymentScriptRemoveDeploymentScriptPowerShell.json
View file
Open in desktop

Large diffs are not rendered by default.

15,928 changes: 404 additions & 15,524 deletions ...ioTests.DeploymentScriptsTests/TestDeploymentScriptRemovePipedDeploymentScriptObject.json
View file
Open in desktop

Large diffs are not rendered by default.

188 changes: 94 additions & 94 deletions ...ests.DeploymentScriptsTests/TestDeploymentScriptTryRemoveNonExistingDeploymentScript.json
View file
Open in desktop

Large diffs are not rendered by default.

28,955 changes: 646 additions & 28,309 deletions ...ests.DeploymentScriptsTests/TestDeploymentScriptTrySaveNonExistingFilePathForLogFile.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Resources/Resources.Test/TemplateScriptDeployment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
{
"type": "Microsoft.Resources/deploymentScripts",
"name": "[variables('scriptName')]",
"apiVersion": "2019-10-01-preview",
"apiVersion": "2020-10-01",
"location": "[resourceGroup().location]",
"kind": "[parameters('scriptKind')]",
"identity": {
Expand Down
2 changes: 1 addition & 1 deletion src/Resources/Resources.Test/TemplateScriptDeploymentCli.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
{
"type": "Microsoft.Resources/deploymentScripts",
"name": "[variables('scriptName')]",
"apiVersion": "2019-10-01-preview",
"apiVersion": "2020-10-01",
"location": "[resourceGroup().location]",
"kind": "[parameters('scriptKind')]",
"identity": {
Expand Down
2 changes: 2 additions & 0 deletions src/Resources/Resources/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
* Overview of change #1
- Additional information about change #1
-->

## Upcoming Release
* Fixed a NullRef exception issue in `New-AzureManagedApplication` and `Set-AzureManagedApplication`.
* Updated Azure Resource Manager SDK to use latest DeploymentScripts GA api-version: 2020-10-01.

## Version 3.1.0
* Added `-Tag` parameter support to `Set-AzTemplateSpec` and `New-AzTemplateSpec`
Expand Down