Skip to content

Prediction/Commands Service API v2 updates #13767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2020
Merged

Prediction/Commands Service API v2 updates #13767

merged 5 commits into from
Dec 18, 2020

Conversation

jjaguirre394
Copy link
Contributor

Description

The Aladdin service is releasing v2 API endpoints to allow for version support of the Predictions and Commands endpoints. This would allow this Powershell client to query the model for predictions based on the module version.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost ghost added the customer-reported label Dec 16, 2020
@ghost
Copy link

ghost commented Dec 16, 2020

Thank you for your contribution jjaguirre394! We will review the pull request and get back to you soon.

@jjaguirre394 jjaguirre394 requested a review from kceiw December 16, 2020 23:14
// limitations under the License.
// ----------------------------------------------------------------------------------

using Newtonsoft.Json;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same to other files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we use the built-in json serialization over the Newtonsoft one? I ask because it seems the built-in version wasn't able to parse the string into the objects I had defined. I'm sure it is possible but I found that the Newtonsoft library was able to do it without any issue. If we really don't want to have a dependency on this library, I can find out how to do this using the built-in version.

- Removed unnecessary usings
- Added copyright
- Misc. code clean up
@wyunchi-ms wyunchi-ms merged commit 5acf8ec into Azure:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants