Skip to content

[KeyVault] Fix minor bugs #13779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2020
Merged

[KeyVault] Fix minor bugs #13779

merged 2 commits into from
Dec 20, 2020

Conversation

isra-fel
Copy link
Member

@isra-fel isra-fel commented Dec 18, 2020

Description

Fix #13583 fix #13584 (more info in the issue)

Although remvoving position from positional parameters is a breaking change, but the scenario never worked before, so it should be fine.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel added this to the S180 (2020-12-29) milestone Dec 18, 2020
@isra-fel
Copy link
Member Author

Because I removed positions, static analysis should complain about breakign change, I'll suppress them later.

@wyunchi-ms wyunchi-ms merged commit f220a97 into Azure:master Dec 20, 2020
@isra-fel isra-fel deleted the fix-13583-13584 branch December 21, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants