Skip to content

Fix the incorrect warning message for Resource #13821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

Youri970410
Copy link
Contributor

@Youri970410 Youri970410 commented Dec 23, 2020

Description

Fix the incorrect warning message for Resource
Fix #13817

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel
Copy link
Member

Please write "fix #xxxxx" in PR message so when the pull request is merged the linked issue will be closed as well. Thanks

@isra-fel isra-fel merged commit 4b187b1 into Azure:master Dec 23, 2020
@Youri970410
Copy link
Contributor Author

Please write "fix #xxxxx" in PR message so when the pull request is merged the linked issue will be closed as well. Thanks

Got it,thanks for your reminder.

dingmeng-xue added a commit that referenced this pull request Dec 25, 2020
* Delete the useless case for costmanagement (#13810)

* delete useless test

* delete useless file

* add liveonly test case for secret management extension (#13809)

* Update the Warning message (#13821)

* Update New-AzHostGroup.md (#13814)

* Fix the test framework for test. (#13803)

* Fix cases and utils script for 'BotService' (#13813)

* Fix cases and utils script for 'BotService'

* update env file

* Add SubscriptionId in cmdlet ’New-AzBotService‘

* update the cmdlet 'New-AzBotservice'

* Update custome file

* Change Get-AzAlertHistory title and description (#13816)

* change alert history title and description

* add release note to change log

* remove changelog

as only doc was changed

Co-authored-by: Yeming Liu <[email protected]>

* [KubernetesConfiguration] Upgrade API version from 2019-11-01-preview to 2020-10-01-preview. (#13829)

* [KubernetesConfiguration] Upgrade API version from 2019-11-01-preview to 2020-10-01-preview.

* [KubernetesConfiguration] Updated ChangeLog.md

* [KubernetesConfiguration] update help doc.

* Update example (#13837)

Updated the example to match the correct cmdlet and removed duplicated parameter.

Co-authored-by: Youri970410 <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: kceiw <[email protected]>
Co-authored-by: hutzleo <[email protected]>
Co-authored-by: Yeming Liu <[email protected]>
Co-authored-by: LucasYao93 <[email protected]>
Co-authored-by: javiermarasco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Warning Message
2 participants