-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix bug causing Docker Password to be removed from appsettings in Set-AzWebApp(Slot) #13866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution Willem-J-an! We will review the pull request and get back to you soon. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
First build failed due to SecureString being compared to a string, pushed a fix for this
|
Thanks @Willem-J-an , this code is related to pull request #12107 by @vinisoto . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for fixing this.
Adding @panchagnula as FYI
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Rebased to resolve conflict on the changelog |
to make sure the versioning script will handle it correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Fix for issue: #13865
Streamlined actions for docker password with the actions for other docker related app settings, so:
This should cause the app setting not to be removed when the parameter is not provided.
Unfortunately I have been unable to build the project locally:
Assets file '\azure-powershell\src\Websites\Websites.Test\obj\project.asses\Websites.Test\obj\project.assets.json' doesn't have a target for 'netcoreapp2.2'. Ensure that restore has run and that you have included 'netcoreapp2.2' in the TargetFrameworks for your project. [C:\hell\src\Websites\Websites.Test\azure-powershell\src\Websites\Websites.Test\Websites.Test.csproj] [\azure-powershell\build.proj].
I installed dotnet 5 and dotnet 2.2, but no luck. I have therefore not been able to run tests for these changes.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added