Skip to content

Do not get nested deployment operations if the nested deployment is i… #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.ActiveDirectoryTests\TestGetADUserWithMail.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentTests\TestNestedDeploymentFromTemplateFile.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.Resources.Test.ScenarioTests.DeploymentTests\TestNewDeploymentFromTemplateFile.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
Expand Down Expand Up @@ -550,6 +553,12 @@
<None Include="sampleTemplateParams.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="sampleNestedTemplate.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Include="sampleNestedTemplateParams.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ public void TestNewDeploymentFromTemplateFile()
ResourcesController.NewInstance.RunPsTest("Test-NewDeploymentFromTemplateFile");
}

[Fact]
public void TestNestedDeploymentFromTemplateFile()
{
ResourcesController.NewInstance.RunPsTest("Test-NestedDeploymentFromTemplateFile");
}

[Fact(Skip = "Fix acquisition of TenantId in KeyVault Test.")]
public void TestNewDeploymentWithKeyVaultReference()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,41 @@ function Test-NewDeploymentFromTemplateFile
}
}

<#
.SYNOPSIS
Tests nested deployment.
#>
function Test-NestedDeploymentFromTemplateFile
{
# Setup
$rgname = Get-ResourceGroupName
$rname = Get-ResourceName
$rglocation = Get-ProviderLocation ResourceManagement
$location = Get-ProviderLocation "Microsoft.Web/sites"

try
{
# Test
New-AzureRmResourceGroup -Name $rgname -Location $rglocation

$deployment = New-AzureRmResourceGroupDeployment -Name $rname -ResourceGroupName $rgname -TemplateFile sampleNestedTemplate.json -TemplateParameterFile sampleNestedTemplateParams.json

# Assert
Assert-AreEqual Succeeded $deployment.ProvisioningState

$subId = (Get-AzureRmContext).Subscription.SubscriptionId
$deploymentId = "/subscriptions/$subId/resourcegroups/$rgname/providers/Microsoft.Resources/deployments/$rname"
$getById = Get-AzureRmResourceGroupDeployment -Id $deploymentId
Assert-AreEqual $getById.DeploymentName $deployment.DeploymentName
}

finally
{
# Cleanup
Clean-ResourceGroup $rgname
}
}

<#
.SYNOPSIS
Tests deployment via template file and parameter file with KeyVault reference.
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
"contentVersion": "1.0.0.0",
"parameters": {
"StorageAccountName": {
"type": "String"
}
},
"variables": {
"templatelink": "https://raw.githubusercontent.com/vivsriaus/armtemplates/master/newStorageAccount.json"
},
"resources": [{
"apiVersion": "2015-01-01",
"name": "nestedTemplate",
"type": "Microsoft.Resources/deployments",
"properties": {
"mode": "incremental",
"templateLink": {
"uri": "[variables('templatelink')]",
"contentVersion": "1.0.0.0"
},
"parameters": {
"StorageAccountName": {
"value": "[parameters('StorageAccountName')]"
}
}
}
}]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json#",
"contentVersion": "1.0.0.0",
"parameters": {
"StorageAccountName": {
"value": "testvivek52134"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
using Hyak.Common;
using Microsoft.Azure.Commands.Resources.Models.Authorization;
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Components;
using Microsoft.Azure.Commands.ResourceManager.Cmdlets.Utilities;
using Microsoft.Azure.Commands.Tags.Model;
using Microsoft.Azure.Common.Authentication;
using Microsoft.Azure.Common.Authentication.Models;
Expand All @@ -34,6 +35,7 @@
using Microsoft.WindowsAzure.Commands.Utilities.Common;
using Newtonsoft.Json;
using ProjectResources = Microsoft.Azure.Commands.Resources.Properties.Resources;
using System.Net;

namespace Microsoft.Azure.Commands.Resources.Models
{
Expand Down Expand Up @@ -340,16 +342,21 @@ private List<DeploymentOperation> GetNewOperations(List<DeploymentOperation> old
//If nested deployment, get the operations under those deployments as well
if(operation.Properties.TargetResource.ResourceType.Equals(Constants.MicrosoftResourcesDeploymentType, StringComparison.OrdinalIgnoreCase))
{
List<DeploymentOperation> newNestedOperations = new List<DeploymentOperation>();
DeploymentOperationsListResult result;
HttpStatusCode statusCode;
Enum.TryParse<HttpStatusCode>(operation.Properties.StatusCode, out statusCode);
if(!statusCode.IsClientFailureRequest())
{
List<DeploymentOperation> newNestedOperations = new List<DeploymentOperation>();
DeploymentOperationsListResult result;

result = ResourceManagementClient.DeploymentOperations.List(
resourceGroupName: ResourceIdUtility.GetResourceGroupName(operation.Properties.TargetResource.Id),
deploymentName: operation.Properties.TargetResource.ResourceName,
parameters: null);
result = ResourceManagementClient.DeploymentOperations.List(
resourceGroupName: ResourceIdUtility.GetResourceGroupName(operation.Properties.TargetResource.Id),
deploymentName: operation.Properties.TargetResource.ResourceName,
parameters: null);

newNestedOperations = GetNewOperations(operations, result.Operations);
newOperations.AddRange(newNestedOperations);
newNestedOperations = GetNewOperations(operations, result.Operations);
newOperations.AddRange(newNestedOperations);
}
}
}

Expand Down