Skip to content

Fixed the storage cmdlets alias not in resource mode bug #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 3, 2015

Conversation

blueww
Copy link
Member

@blueww blueww commented Dec 2, 2015

Fixed the storage cmdlets alias not in resource mode bug

@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Dec 2, 2015

Hi @blueww, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (weiwei). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@hovsepm
Copy link
Contributor

hovsepm commented Dec 2, 2015

@azuresdkci add to whitelist

@hovsepm
Copy link
Contributor

hovsepm commented Dec 2, 2015

@hovsepm
Copy link
Contributor

hovsepm commented Dec 2, 2015

@@ -8,6 +8,9 @@
<Component Id="cmp0761C025FCF8EF027A5BC23C72777C52" Guid="*">
<File Id="fil80798000B169AC6D62DD8331A55CF6FF" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\Azure.Storage\Azure.Storage.psd1" />
</Component>
<Component Id="cmpCC0D4240D3640D2D425852E0F2A4D31E" Guid="*">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be added - the shortcut should not be added to ASM cmdlets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a script to define cmdlet aliases.Is there any particular reason that we cannot call script when loading a module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaZhu @blueww No, I'm saying the script should only be copied into the folder you need it, not into 3 folders. To be clear, it should only be copied into ResourceManager\Azure.Storage...

markcowl added a commit that referenced this pull request Dec 3, 2015
Fixed the storage cmdlets alias not in resource mode bug
@markcowl markcowl merged commit eaa63d3 into Azure:dev Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants