-
Notifications
You must be signed in to change notification settings - Fork 4k
Remove FilterExpression from Get-AzVMImage documentation #13952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msJinLei
approved these changes
Jan 14, 2021
msJinLei
suggested changes
Jan 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failed test case
2021-01-14T06:34:39.5411810Z [xUnit.net 00:02:52.23] Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests.TestVMImageCmdletOutputFormat [FAIL]
2021-01-14T06:34:41.6506855Z X Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests.TestVMImageCmdletOutputFormat [1s 253ms]
2021-01-14T06:34:41.6940930Z EXEC : error Message: [D:\a\1\s\build.proj]
2021-01-14T06:34:41.6941747Z System.Management.Automation.RuntimeException : Assertion failed: $output.Contains($str)
2021-01-14T06:34:41.6942391Z ---- System.Management.Automation.RuntimeException : Assertion failed: $output.Contains($str)
2021-01-14T06:34:41.6942810Z Stack Trace:
2021-01-14T06:34:41.6943216Z at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
2021-01-14T06:34:41.6943735Z at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
2021-01-14T06:34:41.6944361Z at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
2021-01-14T06:34:41.6945300Z at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2021-01-14T06:34:41.6946108Z at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2021-01-14T06:34:41.6946951Z at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
2021-01-14T06:34:41.6947554Z at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
2021-01-14T06:34:41.6948054Z at System.Management.Automation.PowerShell.Invoke()
2021-01-14T06:34:41.6948775Z at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\1\s\tools\ScenarioTest.ResourceManager\EnvironmentSetupHelper.cs:line 573
2021-01-14T06:34:41.6949654Z at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScript(String[] scripts) in D:\a\1\s\tools\TestFx\TestManager.cs:line 227
2021-01-14T06:34:41.7018545Z at Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests.TestVMImageCmdletOutputFormat() in D:\a\1\s\src\Compute\Compute.Test\ScenarioTests\VirtualMachineTests.cs:line 150

msJinLei
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the PS design request, https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/563 , the FilterExpression parameter was never added and should be removed.
Description
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added