Skip to content

Add Microsoft.CLU and clurun to the powershell repo #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2015
Merged

Conversation

johanste
Copy link
Member

@johanste johanste commented Dec 4, 2015

Mostly adding the Microsoft.CLU bits from the private repo.

Changes to existing code:

  • Remove azure.bat from command packages as that is no longer needed
  • Update name of the Microsoft.CLU command package to avoid conflicts between the nugget package projects are supposed to reference when building commandlet based command packages and the (name kept as Microsoft.CLU) and the runtime command package intended to be installed by clurun and used to execute commandlet based packages (which is now called Microsoft.CLU.Commands).
  • Minor tweak to build script to special case the build of Microsoft.CLU.Commands package as that is the only package that shouldn't include an azure.lx file (it doesn't expose commands for azure)

Johan Stenberg (johanste) added 3 commits December 4, 2015 01:26
…onflicts between the Microsoft.CLU package (which is used for building commandlets/adding a reference in your project) and Microsoft.CLU.Commands (which is the command package installed and used by clurun at runtime)
…s the only command package that shouldn't include azure.lx

- No longer include the azure.bat file in the package as that is not needed.
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

azurecla commented Dec 4, 2015

Hi @johanste, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (johanste). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl
Copy link
Member

markcowl commented Dec 4, 2015

@azuresdkci add to whitelist

@markcowl
Copy link
Member

markcowl commented Dec 7, 2015

@johanste Ithis is too large to review in GitHub, so, I will pull down locally, make sure the packages still build and run, and merge if no issues.

@markcowl
Copy link
Member

markcowl commented Dec 7, 2015

@johanste One issue: in Microsoft.CLU.Run\project.json - the references to NuGet.Commands does not work unless you change the version to 3.3.0. Please make this change or update nugget config to take in the appropriate feed to get 3.3.0-local

markcowl added a commit that referenced this pull request Dec 7, 2015
Add Microsoft.CLU and clurun to the powershell repo
@markcowl markcowl merged commit 26579ee into Azure:clu Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants