Skip to content

Updated Set-AzExpressRouteGateway to allow either one of -MinScaleUnits and -MaxScaleUnits #14145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Updated Set-AzExpressRouteGateway to allow either one of -MinScaleUnits and -MaxScaleUnits #14145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Network/Network/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- Added deprecation attribute warning to the old cmdlets.
* Bug fix in ExpressRouteLink MacSecConfig. Added new property `SciState` to `PSExpressRouteLinkMacSecConfig`
* Updated format list and format table views for Get-AzVirtualNetworkGatewayConnectionIkeSa
* Updated `set-azExpressRouteGateway` to allow parameter -MinScaleUnits without specifying -MaxScaleUnits

## Version 4.5.0
* Added new cmdlets for CRUD of VpnGatewayNATRule.
Expand Down
4 changes: 3 additions & 1 deletion src/Network/Network/Cortex/ExpressRouteGateway/SetAzureRmExpressRouteGatewayCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,13 @@ public class UpdateAzureRmExpressRouteGatewayCommand : ExpressRouteGatewayBaseCm
[Parameter(
Mandatory = false,
HelpMessage = "Min for the scale units for this ExpressRouteGateway.")]
[ValidateRange(1, 100)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already validating bounds in NRP, so this will just fail the call earlier.

public uint MinScaleUnits { get; set; }

[Parameter(
Mandatory = false,
HelpMessage = "Max for the scale units for this ExpressRouteGateway.")]
[ValidateRange(1, 100)]
public uint MaxScaleUnits { get; set; }

[Parameter(
Expand Down Expand Up @@ -116,7 +118,7 @@ public override void Execute()
throw new PSArgumentException(Properties.Resources.ExpressRouteGatewayNotFound);
}

if (this.MinScaleUnits > 0 && this.MaxScaleUnits > 0)
if (this.MinScaleUnits > 0 || this.MaxScaleUnits > 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if one of these parameters was not present, can you please confirm whether line 128/129 still work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will set the parameter to 0, which is the expected behavior.

{
if (this.MinScaleUnits > this.MaxScaleUnits)
{
Expand Down