Skip to content

[Storage] Fix a issue cause SDK breaking change #14303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

blueww
Copy link
Member

@blueww blueww commented Feb 24, 2021

Description

This is to fix a create/update account failure caused by breaking change of SDK.
The Identity.Type must give a value before send to server now. (Before will have default value since only 1 available value.)

Since there are no interface change, no design doc need.
Since it's a part of upgrade SDK (already in change log), so no additional change log needed.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@blueww blueww changed the title Fix a issue cause SDK breaking change [Storage] Fix a issue cause SDK breaking change Feb 24, 2021
@blueww
Copy link
Member Author

blueww commented Feb 24, 2021

close, as PR #14307 opened.

@blueww blueww closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants