Skip to content

Added new cmdlets for Diagnostics #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Dec 22, 2015
Merged

Added new cmdlets for Diagnostics #1434

merged 21 commits into from
Dec 22, 2015

Conversation

SiddharthChatrolaMs
Copy link
Contributor

Fixing powershell documentation
Upgrade to latest azure redis management package
Cmdlets for enabling and disabling Diagnostics
Warning message in all managed cache commands

@azurecla
Copy link

azurecla commented Dec 7, 2015

Hi @SiddharthChatrolaMs, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (sichatro). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@SiddharthChatrolaMs SiddharthChatrolaMs changed the title Fixing comments and upgrading management nuget version Added new cmdlets for Diagnostics Dec 10, 2015
@markcowl
Copy link
Member

@SiddharthChatrolaMs There are merge conflicts, please update

markcowl
markcowl reviewed Dec 17, 2015
View reviewed changes
src/ResourceManager/RedisCache/Commands.RedisCache.Test/Commands.RedisCache.Test.csproj
<Reference Include="Microsoft.Azure.Management.Redis, Version=1.0.0.0, Culture=neutral, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Azure.Management.Redis.1.1.0-preview\lib\net40\Microsoft.Azure.Management.Redis.dll</HintPath>
<Reference Include="Microsoft.Azure.Insights, Version=0.9.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
<HintPath>..\..\..\packages\Microsoft.Azure.Insights.0.9.1-preview\lib\net45\Microsoft.Azure.Insights.dll</HintPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is updated for all libraries using Insights. This will also require a wix file update

@markcowl
Copy link
Member

@SiddharthChatrolaMs Also, please update the module version in AzureRm.RedisCache.psd1

@SiddharthChatrolaMs
Copy link
Contributor Author

@markcowl Fixed wix file. (When generated wix it contained lot of changes in non-redis projects, I have reverted them and just pushed redis related fix)

stankovski added a commit that referenced this pull request Dec 22, 2015
@stankovski
Merge pull request #1434 from SiddharthChatrolaMs/dev
005fdc9 
Added new cmdlets for Diagnostics
@stankovski stankovski merged commit 005fdc9 into Azure:dev Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SiddharthChatrolaMs @azurecla @markcowl @stankovski