Skip to content

Reimplementing the exisiting Automation cmdlets and adding new cmdlets #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 102 commits into from
Feb 10, 2015

Conversation

elvg
Copy link
Contributor

@elvg elvg commented Feb 6, 2015

We are updating our existing cmdlets because of our new Automation MAML (not released yet) and adding new cmdlets for other Automation Resources likes certificates, variables, modules, etc.

Note that our PR hasn't been merged yet, that's why we haven't changed the MAML package version in our project. You can see the PR for azure-sdk-for-net from here: Azure/azure-sdk-for-net#948

Please Do Not merge until we change the MAML package version.

Thanks.

elvg and others added 30 commits December 10, 2014 17:44
Merge all changes from mpenta and kirab
Conflicts:
	src/ServiceManagement/Automation/Commands.Automation.Test/Commands.Automation.Test.csproj
	src/ServiceManagement/Automation/Commands.Automation/Commands.Automation.csproj
	src/ServiceManagement/Automation/Commands.Automation/Common/AutomationClient.cs
	src/ServiceManagement/Automation/Commands.Automation/Common/AutomationCmdletParameterSet.cs
	src/ServiceManagement/Automation/Commands.Automation/Common/Constants.cs
	src/ServiceManagement/Automation/Commands.Automation/Common/IAutomationClient.cs
	src/ServiceManagement/Automation/Commands.Automation/Properties/Resources.Designer.cs
	src/ServiceManagement/Automation/Commands.Automation/Properties/Resources.resx
… to due compile issues.. need to pull from mpenta
@azurecla
Copy link

azurecla commented Feb 6, 2015

Hi @elvg, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (elvg). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl
Copy link
Member

markcowl commented Feb 7, 2015

@elvg Please fix test failures

@markcowl
Copy link
Member

markcowl commented Feb 9, 2015

@elvg please fix build issue - looks like you need to have the correct version of automation cmdlets?

@elvg
Copy link
Contributor Author

elvg commented Feb 9, 2015

@markcowl since SDK hasn't merged yet, we don't have our automation SDK released with that version. We are still waiting it to be merged in azure-sdk-for-net.

@markcowl
Copy link
Member

markcowl commented Feb 9, 2015

@elvg, the azure-sdk-for-net PR is merged

@@ -17,7 +17,8 @@
Checks whether the first string contains the second one
#>

$accountName='AutomationAccount'
$accountName='safeer'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's little bit awkward to have account name with a real person. Maybe automatedAccount is better?`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this but we would like to change it in next release.

markcowl added a commit that referenced this pull request Feb 10, 2015
Reimplementing the exisiting Automation cmdlets and adding new cmdlets
@markcowl markcowl merged commit 60df675 into Azure:dev Feb 10, 2015
@elvg
Copy link
Contributor Author

elvg commented Feb 10, 2015

Thanks!

ogail pushed a commit that referenced this pull request Aug 27, 2015
Scrubbing help text. Signed off by SureshT.
AzureRT referenced this pull request in AzureRT/azure-powershell Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants