-
Notifications
You must be signed in to change notification settings - Fork 4k
Reimplementing the exisiting Automation cmdlets and adding new cmdlets #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge all changes from mpenta and kirab
Conflicts: src/ServiceManagement/Automation/Commands.Automation.Test/Commands.Automation.Test.csproj src/ServiceManagement/Automation/Commands.Automation/Commands.Automation.csproj src/ServiceManagement/Automation/Commands.Automation/Common/AutomationClient.cs src/ServiceManagement/Automation/Commands.Automation/Common/AutomationCmdletParameterSet.cs src/ServiceManagement/Automation/Commands.Automation/Common/Constants.cs src/ServiceManagement/Automation/Commands.Automation/Common/IAutomationClient.cs src/ServiceManagement/Automation/Commands.Automation/Properties/Resources.Designer.cs src/ServiceManagement/Automation/Commands.Automation/Properties/Resources.resx
… to due compile issues.. need to pull from mpenta
Hi @elvg, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
@elvg Please fix test failures |
@elvg please fix build issue - looks like you need to have the correct version of automation cmdlets? |
@markcowl since SDK hasn't merged yet, we don't have our automation SDK released with that version. We are still waiting it to be merged in azure-sdk-for-net. |
@elvg, the azure-sdk-for-net PR is merged |
StreamType should be enum + unit test fixed
@@ -17,7 +17,8 @@ | |||
Checks whether the first string contains the second one | |||
#> | |||
|
|||
$accountName='AutomationAccount' | |||
$accountName='safeer' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's little bit awkward to have account name with a real person. Maybe automatedAccount
is better?`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching this but we would like to change it in next release.
Reimplementing the exisiting Automation cmdlets and adding new cmdlets
Thanks! |
Scrubbing help text. Signed off by SureshT.
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
We are updating our existing cmdlets because of our new Automation MAML (not released yet) and adding new cmdlets for other Automation Resources likes certificates, variables, modules, etc.
Note that our PR hasn't been merged yet, that's why we haven't changed the MAML package version in our project. You can see the PR for azure-sdk-for-net from here: Azure/azure-sdk-for-net#948
Please Do Not merge until we change the MAML package version.
Thanks.