Skip to content

Add vulnerability assessment cmdlets for IAAS in Az.Security #14607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 2, 2021
Merged

Add vulnerability assessment cmdlets for IAAS in Az.Security #14607

merged 25 commits into from
Apr 2, 2021

Conversation

a7mad-3bbas
Copy link
Contributor

Description

Add Sql Vulnerability Assessment cmdlets for IAAS in Az.Security:
Get-AzSqlVulnerabilityAssessmentScanRecord
Get-AzSqlVulnerabilityAssessmentScanResult
Add-AzSqlVulnerabilityAssessmentBaselineRule
Remove-AzSqlVulnerabilityAssessmentBaselineRule
Get-AzSqlVulnerabilityAssessmentBaselineRule
Set-AzSqlVulnerabilityAssessmentBaselineRule

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

BethanyZhou
BethanyZhou reviewed Mar 22, 2021
View reviewed changes
BethanyZhou
BethanyZhou reviewed Mar 22, 2021
View reviewed changes
@a7mad-3bbas
Copy link
Contributor Author

SqlVulnerabilityAssessmentSetBaselineBase is used for both: "SetSqlVulnerabilityAssessmentBaselineRule" and "AddSqlVulnerabilityAssessmentBaselineRule" so having a common class is better than duplicating the code. maybe you have a better suggestion for renaming the class in order to indicate that it is used by both of there?

@BethanyZhou
Copy link
Contributor

SqlVulnerabilityAssessmentSetBaselineBase is used for both: "SetSqlVulnerabilityAssessmentBaselineRule" and "AddSqlVulnerabilityAssessmentBaselineRule" so having a common class is better than duplicating the code. maybe you have a better suggestion for renaming the class in order to indicate that it is used by both of there?

Sorry, I didn't catch that. How about renaming SqlVulnerabilityAssessmentSetBaselineBase to SqlVulnerabilityAssessmentBaseWithBaseline?

BethanyZhou
BethanyZhou suggested changes Mar 26, 2021
View reviewed changes
BethanyZhou
BethanyZhou suggested changes Apr 1, 2021
View reviewed changes
@BethanyZhou
Copy link
Contributor

Hi @a7mad-3bbas , could you update its corresponding design review to latest status? Current implement is far from we considered before.

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Apr 1, 2021 •
edited
Loading

/azp run azure-powershell - powershell-core

@Azure Azure deleted a comment from azure-pipelines bot Apr 1, 2021
@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@BethanyZhou
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli merged commit 8bcc63f into Azure:master Apr 2, 2021
wyunchi-ms pushed a commit that referenced this pull request Apr 7, 2021
@a7mad-3bbas @wyunchi-ms
Add vulnerability assessment cmdlets for IAAS in Az.Security (#14607)
5c650da 
* Add sql vulnerability assessment model

* temp

* Add Sql Vulnerability asessment model +  Cmdlets implementation

* add Documentation files

* Fix design review comments

* Add test scenario

* Add Tests

* Add vm domail label to creating vm in test

* adjust the reference for monitoringSolutions

* Change test category to live only.

* Remove unnecessary dependencies

* sync repo and update versions

* update changelog.md

* Fix PR comments

* Modify mark down files and add examples

* Rename baseline cmdlets

* rename files for baseline cmdlets

* Add Examples for set baseline cmdlet + some final adjustments to the documentation

* Fixed PR comments.

* Fix some static analysis issues

* Add module name to cmdlets to distinguish them from PAAS cmdlets.

* Rename files.

* Add should process + rename help files.

* update documentation.

* fix rename issues from tests.

Co-authored-by: Ahmad Abas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyZhou BethanyZhou BethanyZhou approved these changes

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a7mad-3bbas @BethanyZhou @dolauli