Skip to content

Support aliases for ValueFromPipelineByPropertyName parameters. #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Support aliases for ValueFromPipelineByPropertyName parameters. #1461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/CLU/Microsoft.CLU/CommandBinder/Pipeline/PipelineParametersBinder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,23 @@ private bool BindParametersToDocumentDataByProperty(object instance, IEnumerable
foreach (var parameter in parameters)
{
JToken jtoken;
if (json.TryGetValue(parameter.Name, StringComparison.OrdinalIgnoreCase, out jtoken))

// First look up by name. If we didn't find a match on name, we'll go through all
// aliases to try to find a match.
var foundMatch = json.TryGetValue(parameter.Name, StringComparison.OrdinalIgnoreCase, out jtoken);
if (!foundMatch)
{
foreach (var alias in parameter.Aliases)
{
if (json.TryGetValue(alias, StringComparison.OrdinalIgnoreCase, out jtoken))
{
foundMatch = true;
break;
}
}
}

if (foundMatch)
{
parameterSets.IntersectWith(parameter.ParameterSets.Keys.ToSet());
if (parameter.ParameterType.Equals(typeof(string)) || parameter.ParameterType.GetTypeInfo().IsEnum)
Expand Down