Skip to content

Update properties of Search-AzGraph in regard to the new GA API version #14639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2021

Conversation

fenwickt
Copy link
Contributor

@fenwickt fenwickt commented Mar 25, 2021

Description

Added changes to ResourceGraph cmdlet Search-AzGraph to reflect recent GA version.

  • ManagementGroup param was added so that users can pass up to 10 management groups as a query scope
  • AllowPartialScope param was added to support results for partial scope set if user query hits max number of scopes supported by the server
  • Include param got removed. Users can get subscription name by querying Containers table directly
  • SkipToken param was added. Users can pass this param to get the next page of resources
  • Max number of resources per page was decreased from 5000 to 1000 to align the server configurations. Users can get the next pages by using -SkipToken param

Issue https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/893

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@fenwickt fenwickt requested a review from BethanyZhou March 31, 2021 02:41
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou BethanyZhou merged commit 21a7a7d into Azure:master Mar 31, 2021
wyunchi-ms pushed a commit that referenced this pull request Apr 7, 2021
…on (#14639)

* new api version changes and help generated

* tests added and fixed

* updated recordings and added skip token test

* added change log and updated skipToken logic to align with REST behaviour

* update assembly info to 0.9.0

* reverted version change, let subscriptions that are already preset in context to be passed

* deleted resource graph from the local feed as lib is published online

Co-authored-by: makharch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants