-
Notifications
You must be signed in to change notification settings - Fork 4k
Cmdlets for Cross server gt #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conflicts: src/ResourceManager/Sql/Commands.Sql.Test/packages.config src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj src/ResourceManager/Sql/Commands.Sql/Properties/Resources.resx src/ResourceManager/Sql/Commands.Sql/packages.config
The server communication link tests will be re-enabled as soon as the feature is fully deployed to the region the tests use.
Can one of the admins verify this patch? |
Hi @adumitr, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Is it at all possible to get this merged today? Also, after, please send me some details on how to get the changes published so they become publicly accessible (my alias is adumitr) |
@azuresdkci add to whitelist |
After another build fix and retrying a few builds to get flaky tests to pass, finally got a successful build. Can we complete this merge? Thanks |
what is the status with this pull request? It says checks have been pending for way too long, plus there had been a prior successful build that passed all checks. What does it take at this point to complete this? |
@azuresdkci retest this please |
{ | ||
[Cmdlet(VerbsCommon.Get, "AzureRmSqlServerCommunicationLink", | ||
ConfirmImpact = ConfirmImpact.None)] | ||
public class GetAzureSqlServerCommunicationLink : AzureSqlServerCommunicationLinkCmdletBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adumitr What is the OutputType for this cmdlet? Please add the attribute for OutputType with the cmdlet OutputType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Is anyone still around to merge this? |
@adumitr please fix merge conflicts |
Resolved conflicts. Does the merge work now? |
Cmdlets for Cross server gt
No description provided.