Skip to content

Cmdlets for Cross server gt #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 26, 2015
Merged

Cmdlets for Cross server gt #1471

merged 7 commits into from
Dec 26, 2015

Conversation

adumitr
Copy link
Contributor

@adumitr adumitr commented Dec 10, 2015

No description provided.

Conflicts:
	src/ResourceManager/Sql/Commands.Sql.Test/packages.config
	src/ResourceManager/Sql/Commands.Sql/Commands.Sql.csproj
	src/ResourceManager/Sql/Commands.Sql/Properties/Resources.resx
	src/ResourceManager/Sql/Commands.Sql/packages.config
The server communication link tests will be re-enabled as soon as the feature is fully
deployed to the region the tests use.
@azuresdkci
Copy link

Can one of the admins verify this patch?

@azurecla
Copy link

Hi @adumitr, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (adumitr). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@adumitr
Copy link
Contributor Author

adumitr commented Dec 11, 2015

Is it at all possible to get this merged today? Also, after, please send me some details on how to get the changes published so they become publicly accessible (my alias is adumitr)

@markcowl
Copy link
Member

@azuresdkci add to whitelist

@adumitr
Copy link
Contributor Author

adumitr commented Dec 16, 2015

After another build fix and retrying a few builds to get flaky tests to pass, finally got a successful build. Can we complete this merge? Thanks

@adumitr
Copy link
Contributor Author

adumitr commented Dec 17, 2015

what is the status with this pull request? It says checks have been pending for way too long, plus there had been a prior successful build that passed all checks. What does it take at this point to complete this?

@markcowl
Copy link
Member

@azuresdkci retest this please

{
[Cmdlet(VerbsCommon.Get, "AzureRmSqlServerCommunicationLink",
ConfirmImpact = ConfirmImpact.None)]
public class GetAzureSqlServerCommunicationLink : AzureSqlServerCommunicationLinkCmdletBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adumitr What is the OutputType for this cmdlet? Please add the attribute for OutputType with the cmdlet OutputType

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@adumitr
Copy link
Contributor Author

adumitr commented Dec 21, 2015

Is anyone still around to merge this?

@stankovski
Copy link
Member

@adumitr please fix merge conflicts

@adumitr
Copy link
Contributor Author

adumitr commented Dec 23, 2015

Resolved conflicts. Does the merge work now?

stankovski added a commit that referenced this pull request Dec 26, 2015
@stankovski stankovski merged commit 9cd3a43 into Azure:dev Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants