Ensure cmdlet signature for Resources and Websites #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hovsepm
commented
Dec 15, 2015
hovsepm
commented
- [#109784150]
- [#109784164]
| @@ -101,6 +104,7 @@ public class NewAzureRoleAssignmentCommand : ResourcesBaseCmdlet | |||
| [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.ResourceWithSPN, | |||
| HelpMessage = "Parent resource of the resource to assign the role to, if there is any.")] | |||
| [ValidateNotNullOrEmpty] | |||
| [Alias("parent", "p")] | |||
There was a problem hiding this comment.
@hovsepm I think this is too easy to confuse with the other -p (property) - we shoudol try to be consistent with the single character parameters, they should be applicable at least across an RP.
hovsepm
pushed a commit
that referenced
this pull request
Dec 15, 2015
Ensure cmdlet signature for Resources and Websites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.