Skip to content

Azure Networking: Updated saDataSizeKilobytes validation for vpn gateway connection #14897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

misbamomin
Copy link
Contributor

@misbamomin misbamomin commented May 4, 2021

Description

Making the property of IPsec protocol, SALifeTimeSeconds disabled by setting it to zero.

SALifeTimeSeconds is the property of IPsec protocol which is used to reinitialize the Security association (SA) when data is sent over the connection for data security purpose. When there is high throughput SALifeTimeSeconds property of IPsec protocol can become useless.

In the current implementation SALifeTimeSeconds can be passed in between 1024 to 2147483647.

About the current change: when SALifeTimeSeconds value passed 0 it should disable the SALifeTimeSeconds property of IPsec protocol.

I updated the validation and added unit tests in azure PowerShell repository.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@ghost
Copy link

ghost commented May 4, 2021

CLA assistant check
All CLA requirements met.

@misbamomin misbamomin changed the title Updated saDataSizeKilobytes validation Azure Networking: Updated saDataSizeKilobytes validation for vpn gateway connection May 4, 2021
@dingmeng-xue dingmeng-xue changed the base branch from master to network-february May 4, 2021 09:03
@dingmeng-xue
Copy link
Member

dingmeng-xue commented May 4, 2021

Please sign Contributor License Agreement. Otherwise, this PR cannot be merged.

This PR needs to include the update of changelog https://github.com/Azure/azure-powershell/blob/network-february/src/Network/Network/ChangeLog.md except original change is not released yet.

@misbamomin misbamomin changed the base branch from network-february to master May 5, 2021 01:51
@wyunchi-ms wyunchi-ms merged commit 88f7be2 into Azure:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants